Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] fix capitalization of Brave in Privacy Report setting description #11567

Closed
LaurenWags opened this issue Sep 2, 2020 · 1 comment · Fixed by brave/brave-core#8647
Labels
OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude

Comments

@LaurenWags
Copy link
Member

Description

Under Settings > Display > Privacy Report, look at the first setting. The word "brave" should be capitalized and shown as Brave instead.

Steps to reproduce

  1. Install 1.13.x
  2. Go to Settings
  3. Navigate to Display section and open Privacy Report.

Actual result

Look at first setting description
settings

Expected result

brave --> Brave

Issue reproduces how often

easily

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? n/a
  • Can you reproduce this issue with the current Play Store Beta version? yes
  • Can you reproduce this issue with the current Play Store Nightly version? yes

Device details

  • Install type (ARM, x86): all
  • Device type (Phone, Tablet, Phablet): all
  • Android version: all

Brave version

1.13.83

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@LaurenWags LaurenWags added QA/Yes OS/Android Fixes related to Android browser functionality labels Sep 2, 2020
@anthonypkeane anthonypkeane added the priority/P2 A bad problem. We might uplift this to the next planned release. label Oct 28, 2020
@samartnik samartnik added this to the 1.25.x - Nightly milestone Apr 27, 2021
@stephendonner
Copy link

stephendonner commented Apr 28, 2021

Verification passed on the following devices running 1.25.51 x64 beta build

  • Verified Brave is now correctly capitalized under Settings > Privacy Report
Pixel XL (Android 9) Samsung Tab A (Android 10)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants