Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trackers & Ads Blocking Setting Not Persisting #11585

Closed
qazero opened this issue Sep 3, 2020 · 16 comments · Fixed by brave/brave-core#6693
Closed

Trackers & Ads Blocking Setting Not Persisting #11585

qazero opened this issue Sep 3, 2020 · 16 comments · Fixed by brave/brave-core#6693
Assignees
@simonhong
Labels
feature/shields The overall Shields feature in Brave. OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. privacy privacy-pod Feature work for the Privacy & Web Compatibility pod QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include security
Milestone
1.15.x - Release #1

Comments

@qazero
Copy link

qazero commented Sep 3, 2020

Description

Brave's default ad blocking setting is set to Standard out of the box. When I change this to aggressive it seems to work, but when I close Brave and reopen it, then the setting changes back to the default setting of Standard. Why aren't setting persisting between restarts of the browser? I am not having this issue with any of the other settings I've tested, it is only this setting value which isn't persisting.

Steps to Reproduce

  1. Open Brave
  2. Click on Settings > Shields
  3. In the Shields section, change "Trackers & ads blocking" from Standard to Aggressive
  4. Close Brave Browser
  5. Open Brave Browser and go to Settings > Shields
  6. In the Shields section you will find that the "Trackers & ads blocking" setting has reverted back to the default value of Standard

Expected result:

"Trackers & ads blocking" setting should persist and not revert back to the default.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave | 1.13.82 Chromium: 85.0.4183.83 (Official Build) (64-bit)
Revision | 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS | Windows 10 OS Version 2004 (Build 19041.450)
@diracdeltas diracdeltas added privacy security feature/shields The overall Shields feature in Brave. labels Sep 3, 2020
@diracdeltas
Copy link
Member

cc @pes10k

i wonder if this is the same underlying bug as #11525

@qazero what is your default browser language?

@diracdeltas diracdeltas mentioned this issue Sep 3, 2020
Closed
@qazero
Copy link
Author

qazero commented Sep 3, 2020

English

@diracdeltas
Copy link
Member

i think this is the same issue as #10790; closing as dupe. thx

@diracdeltas diracdeltas added the closed/duplicate Issue has already been reported label Sep 3, 2020
@diracdeltas diracdeltas mentioned this issue Sep 3, 2020
Closed
@diracdeltas
Copy link
Member

reopening as it seems like a different issue

@diracdeltas diracdeltas reopened this Sep 3, 2020
@srirambv srirambv removed the closed/duplicate Issue has already been reported label Sep 4, 2020
@srirambv srirambv added the privacy-pod Feature work for the Privacy & Web Compatibility pod label Sep 4, 2020
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 16, 2020 •
edited
Loading

The above issue mentioned in the STR is working for Aggressive settings, but the issue is arising for the Disabled settings option now. After selecting Disabled option for Trackers & Ad blocking in the global shiled settings page, reload page resets the value to default value Standarad. STR is mentioned below:

STR 1:

  1. Open Brave 1.14.x or 1.16.x
  2. Open brave://settings/shields
  3. Change Trackers & Ad blocking to Disabled
  4. Reload the page or restart the browser
  5. Disabled option is reverted back to Standarad

STR 2:

  1. Open Brave 1.12.x or 1.13.x
  2. Open brave://settings/shields
  3. Change Trackers & Ad blocking to Disabled
  4. Upgrdae the profile to 1.14.x
  5. Disabled option is reverted back to Standarad

cc: @pes10k @rebron @kjozwiak

@GeetaSarvadnya GeetaSarvadnya mentioned this issue Sep 16, 2020
Closed
@pes10k
Copy link
Contributor

pes10k commented Sep 17, 2020

@rebron i think @simonhong looked into / fixed something like this a while back. Could this be another version of that?

@diracdeltas diracdeltas added the priority/P2 A bad problem. We might uplift this to the next planned release. label Sep 22, 2020
@rebron rebron self-assigned this Sep 22, 2020
@simonhong simonhong self-assigned this Sep 22, 2020
@simonhong
Copy link
Member

As @GeetaSarvadnya mentioned above, I also can see Disabled option is reverted.

@simonhong simonhong added this to the 1.16.x - Nightly milestone Sep 24, 2020
@simonhong simonhong mentioned this issue Sep 24, 2020
Merged
32 tasks
@rebron rebron mentioned this issue Sep 25, 2020
Closed
@simonhong simonhong mentioned this issue Sep 30, 2020
Merged
4 tasks
@rebron rebron removed their assignment Sep 30, 2020
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 1, 2020 •
edited by btlechowski
Loading

Verification passed on


Brave | 1.15.69 Chromium: 86.0.4240.55 (Official Build) (64-bit)
-- | --
Revision | a6d625ef6f7fe8ea0675f1cf759155a05ee1be40-refs/branch-heads/4240@{#953}
OS | Windows 10 OS Version 1903 (Build 18362.1016)

Verified passed with

Brave	1.15.69 Chromium: 86.0.4240.55 (Official Build) (x86_64)
Revision	a6d625ef6f7fe8ea0675f1cf759155a05ee1be40-refs/branch-heads/4240@{#953}
OS	macOS Version 10.14.6 (Build 18G3020)

Verified STR from #11585 (comment)

Verified STR from #11585 (comment)

Verification passed on

Brave 1.15.69 Chromium: 86.0.4240.55 (Official Build) (64-bit)
Revision a6d625ef6f7fe8ea0675f1cf759155a05ee1be40-refs/branch-heads/4240@{#953}
OS Ubuntu 18.04 LTS

@kjozwiak kjozwiak mentioned this issue Oct 1, 2020
Closed
@qazero
Copy link
Author

qazero commented Nov 1, 2020

This issue has returned in v1.16.68. Could you please reopen this ticket and fix? Thanks

@pes10k
Copy link
Contributor

pes10k commented Nov 2, 2020

@qazero im sorry to hear you're still having this problem! I am not able to reproduce it on my end though. Can you say a bit more about the steps you're taking that trigger the problem and we can dig in further?

@qazero
Copy link
Author

qazero commented Nov 2, 2020

@pes10k Thank you for your response. The steps to reproduce hasn't changed for me since my original post. I'm not sure what extra information I could provide. Please advise. Thanks

@pes10k
Copy link
Contributor

pes10k commented Nov 10, 2020

Hmm, im sorry @qazero but im not able to reproduce on my end… 

If you wouldn't mind, could you answer of these questions if you have a chance?

  1. Do you see it on all pages, or only some?
  2. What are your global / default shield settings (i.e. brave://settings/shields)
  3. Do you still see it in private browsing (if not, that suggests something has gotten goofed in your profile, maybe a migration path we didn't account for… ?)
  4. Do you see it in nightly builds (if you have tested)

@qazero
Copy link
Author

qazero commented Apr 27, 2021

I'm still experiencing this issue. Please find my responses to your questions below:

  1. All
  2. See screenshot below:
    image
  3. Yes
  4. Yes

Just to reiterate here are the steps to reproduce and additional infos below:

Description
Brave's default ad blocking setting is set to Standard out of the box. When I change this to aggressive it seems to work, but when I close Brave and reopen it, then the setting changes back to the default setting of Standard. Why aren't setting persisting between restarts of the browser? I am not having this issue with any of the other settings I've tested, it is only this setting value which isn't persisting.

Steps to Reproduce
Open Brave
Click on Settings > Shields
In the Shields section, change "Trackers & ads blocking" from Standard to Aggressive
Close Brave Browser
Open Brave Browser and go to Settings > Shields
In the Shields section you will find that the "Trackers & ads blocking" setting has reverted back to the default value of Standard
Expected result:
"Trackers & ads blocking" setting should persist and not revert back to the default.

Reproduces how often:
Easily reproduced

Brave version (brave://version info)

Brave 1.23.73 Chromium: 90.0.4430.85 (Official Build) (64-bit)
Revision 5bc145d831c180d9ff94f29a0d7a2e1cbd30ef36-refs/branch-heads/4430@{#1311}
OS Windows 10 OS Version 2009 (Build 19042.928)

@qazero
Copy link
Author

qazero commented Mar 18, 2022

Pls help!!

@kjozwiak
Copy link
Member

kjozwiak commented May 4, 2022

I am having this problem too on macos

@luv2dnce33 if you're experiencing issues, mind creating a new issue? This one is pretty old which was part of a release that went out a while ago. Can you please create a new issue here and add as much information as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
feature/shields The overall Shields feature in Brave. OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. privacy privacy-pod Feature work for the Privacy & Web Compatibility pod QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include security
Projects
None yet
Milestone
1.15.x - Release #1
Development

Successfully merging a pull request may close this issue.

Fixed Disabled ads tracking option is reverted after reloading brave/brave-core
11 participants
@pes10k @diracdeltas @kjozwiak @rebron @simonhong @qazero @srirambv @LaurenWags @btlechowski @GeetaSarvadnya and others