Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Month Option Selected in Brave Reward not updated on @onClick #11613

Closed
Hakamate opened this issue Sep 7, 2020 · 8 comments
Closed

Comments

@Hakamate
Copy link

Hakamate commented Sep 7, 2020

Description

Into Brave rewards :
When you click on another month, informations are updated, but not the month option selected

Steps to Reproduce

  1. Go to : brave://rewards/
  2. Click here :
    image
  3. Select another month

Actual result:

image

Expected result:

Change Selected Option

Brave version (brave://version info)

image

@NejcZdovc
Copy link
Contributor

@brave/legacy_qa did you maybe saw this problem? Just tried it and can't reproduce it on my side

@NejcZdovc NejcZdovc added the needs-more-info The report requires more detail before we can decide what to do with this issue. label Sep 9, 2020
@LaurenWags
Copy link
Member

Looks like it reproduces on

Brave 1.14.73 Chromium: 85.0.4183.83 (Official Build) beta (64-bit)
Revision 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS macOS Version 10.14.6 (Build 18G3020)

The data on the statement itself changes, but the dropdown still says "September 2020" no matter what I select. Ex:

This is actually Sept 2020:
Sept 2020

Here I chose Aug 2020:
Choose Aug

You can see the data reflects Aug 2020, not Sept 2020 as in first screenshot, but dropdown still says Sept 2020:
Dropdown stays Sept

@LaurenWags
Copy link
Member

+1 from #9211 (comment)

@NejcZdovc
Copy link
Contributor

@LaurenWags does this problem exists on the latest nightly?

@LaurenWags
Copy link
Member

Yes.

Brave 1.16.4 Chromium: 85.0.4183.102 (Official Build) nightly (64-bit)
Revision ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS macOS Version 10.14.6 (Build 18G3020)

September:
Screen Shot 2020-09-09 at 12 19 29 PM

Chose August:
Screen Shot 2020-09-09 at 12 19 37 PM

Dropdown shows Sept but statement shows August data:
Screen Shot 2020-09-09 at 12 19 43 PM

@LaurenWags LaurenWags added QA/Yes and removed needs-more-info The report requires more detail before we can decide what to do with this issue. labels Dec 7, 2020
@marshall marshall added the priority/P3 The next thing for us to work on. It'll ride the trains. label Dec 16, 2020
@zenparsing
Copy link

Fixed in brave/brave-core#7615

@stephendonner
Copy link

Verified FIXED on macOS Big Sur (11.2.1) using nightly build:

Brave 1.22.39 Chromium: 89.0.4389.58 (Official Build) nightly (x86_64)
Revision 1a139f28ecc27719439e37c6b1533cee999cb802-refs/branch-heads/4389@{#1134}
OS macOS Version 11.2.1 (Build 20D74)

rewards-feb-and-march

I ran out of testing BAT in this session, so March isn't as complete as it could be, but the transactions I made showed up :-)

@LaurenWags
Copy link
Member

changing from release-notes/include to release-notes/exclude as this was fixed by #13590 which was included in 1.21.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants