-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Desktop] Greaselion content script sometimes doesn't load until restarting browser - follow up to #11837 #11998
Milestone
Comments
Verified passed with
Verified below steps (modified from brave/brave-core#6698):
Verification passed on
Verified below steps (modified from brave/brave-core#6698):
Verification passed on
Verified below steps (modified from brave/brave-core#6698):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Per internal discussions (https://bravesoftware.slack.com/archives/CB0KCRCQN/p1601901591057200), #11837 should be tested when Twitter tipping with Greaselion lands which is expected to be with 1.17.x.
Per process, logging this follow up issue so the issue can be tested in 1.17x.
Test Plan can be found in issue PR: brave/brave-core#6698
Below is the original issue description:
Create a
Greaselion.json
file like the following and a simple script that just printsHello, world!
to the console:If you launch the browser clean (with no open pages) and then navigate to https://twitter.com/emerick, once in a while the content script will not load at all. This occurs maybe 1 in 10 or 1 in 20 times. In addition, no amount of refreshing the page or creating new tabs will cause the content script to load; the only recourse I've found is to restart the browser. I don't see any relevant error messages in the log or console when this occurs, unfortunately.
The text was updated successfully, but these errors were encountered: