Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Greaselion content script sometimes doesn't load until restarting browser - follow up to #11837 #11998

Closed
LaurenWags opened this issue Oct 5, 2020 · 1 comment

Comments

@LaurenWags
Copy link
Member

Per internal discussions (https://bravesoftware.slack.com/archives/CB0KCRCQN/p1601901591057200), #11837 should be tested when Twitter tipping with Greaselion lands which is expected to be with 1.17.x.

Per process, logging this follow up issue so the issue can be tested in 1.17x.

Test Plan can be found in issue PR: brave/brave-core#6698

Below is the original issue description:

Create a Greaselion.json file like the following and a simple script that just prints Hello, world! to the console:

  {
    "urls": [
      "https://twitter.com/*",
      "https://*.twitter.com/*"
    ],
    "scripts": [
      "myscript.js"
    ]
  }

If you launch the browser clean (with no open pages) and then navigate to https://twitter.com/emerick, once in a while the content script will not load at all. This occurs maybe 1 in 10 or 1 in 20 times. In addition, no amount of refreshing the page or creating new tabs will cause the content script to load; the only recourse I've found is to restart the browser. I don't see any relevant error messages in the log or console when this occurs, unfortunately.

@LaurenWags
Copy link
Member Author

LaurenWags commented Oct 12, 2020

Verified passed with

Brave | 1.17.25 Chromium: 86.0.4240.75 (Official Build) nightly (x86_64)
-- | --
Revision | c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
OS | macOS Version 10.14.6 (Build 18G3020)

Verified below steps (modified from brave/brave-core#6698):
pre-req: Create a Greaselion.json file like in PR

  1. Launch browser with a clean profile
  2. Enable Rewards, claim grant
  3. Confirm in-line twitter tips are enabled, which they should be by default
  4. Close Brave.
  5. Replace the existing Greaselion.json file in Library⁩ ▸ ⁨Application Support⁩ ▸ ⁨BraveSoftware⁩ ▸ ⁨Brave-Browser-Nightly⁩ ▸ ⁨afalakplffnnnlkncjhbmahjfjhmlkal⁩ ▸ ⁨1.0.29⁩ ▸ ⁨1 with the one we created above
  6. Relaunch browser
  7. Visit site that matches Greaselion rule with precondition (ex. twitter.com/emerick)
  8. Confirm able to tip via in-line tip button

Verification passed on

Brave 1.17.32 Chromium: 86.0.4240.80 (Official Build) nightly (64-bit)
Revision 7ed88b53bda45a2d19efb4f8706dd6b6cad0d3af-refs/branch-heads/4240@{#1183}
OS Ubuntu 18.04 LTS

Verified below steps (modified from brave/brave-core#6698):
pre-req: Create a Greaselion.json file like in PR

  1. Launch browser with a clean profile
  2. Enable Rewards, claim grant
  3. Confirm in-line twitter tips are enabled, which they should be by default
  4. Close Brave.
  5. Replace the existing Greaselion.json file with the one we created above
  6. Relaunch browser
  7. Visit site that matches Greaselion rule with precondition (ex. twitter.com/emerick)
  8. Confirm able to tip via in-line tip button

Verification passed on

Brave 1.17.69 Chromium: 87.0.4280.60 (Official Build) (64-bit)
Revision 12697cfeb273d7de95cf9b18350d2c457f58224c-refs/branch-heads/4280@{#1352}
OS Windows 7 Service Pack 1 (Build 7601.24544)

Verified below steps (modified from brave/brave-core#6698):
pre-req: Create a Greaselion.json file like in PR

  1. Launch browser with a clean profile
  2. Enable Rewards, claim grant
  3. Confirm in-line twitter tips are enabled, which they should be by default
  4. Close Brave.
  5. Replace the existing Greaselion.json file with the one we created above
  6. Relaunch browser
  7. Visit site that matches Greaselion rule with precondition (ex. twitter.com/emerick)
  8. Confirm able to tip via in-line tip button

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment