Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

downloads bar should show the origin of the download #1269

Closed
diracdeltas opened this issue Sep 25, 2018 · 2 comments · Fixed by brave/brave-core#597
Closed

downloads bar should show the origin of the download #1269

diracdeltas opened this issue Sep 25, 2018 · 2 comments · Fixed by brave/brave-core#597
Assignees
@mkarolin
Labels
audit-release QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes security
Milestone
0.55.x - Release ...

Comments

@diracdeltas
Copy link
Member

diracdeltas commented Sep 25, 2018 •
edited by bsclifton
Loading

Test plan

See brave/brave-core#597

Description

For parity with browser-laptop, when a file is downloaded it should show the origin of the download in the URL bar, preferably marking HTTP as insecure. brave/browser-laptop#7468
@diracdeltas diracdeltas added this to the 1.0 milestone Sep 25, 2018
@bbondy bbondy modified the milestones: 1.0 (0.56.x), Releasable builds 0.55.x Sep 28, 2018
@bbondy bbondy modified the milestones: Releasable builds 0.55.x, 1.0 (0.56.x) Oct 1, 2018
@mkarolin mkarolin mentioned this issue Oct 10, 2018
Merged
18 tasks
mkarolin added a commit to brave/brave-core that referenced this issue Oct 11, 2018
@mkarolin
Show download item origin URL.
b9124e3 
Fixes brave/brave-browser#1269

* Subclasses DownloadItemView to draw the origin URL and the lock icon,
updates accessible name with origin URL;
* Adds the lock icon to vector icons;
* Extends DownloadItemModel to obtain origin URL text and update tooltip
text with origin URL;
* Adds unit tests for BraveDownloadItemModel.
bsclifton pushed a commit to brave/brave-core that referenced this issue Oct 12, 2018
@mkarolin @bsclifton
Show download item origin URL.
eb2ce61 
Fixes brave/brave-browser#1269

* Subclasses DownloadItemView to draw the origin URL and the lock icon,
updates accessible name with origin URL;
* Adds the lock icon to vector icons;
* Extends DownloadItemModel to obtain origin URL text and update tooltip
text with origin URL;
* Adds unit tests for BraveDownloadItemModel.
@bsclifton
Copy link
Member

Uplifted to 0.55.x 😄

@bsclifton bsclifton modified the milestones: 0.56.x, 0.55.x Oct 13, 2018
@LaurenWags LaurenWags mentioned this issue Oct 15, 2018
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Oct 15, 2018 •
edited by btlechowski
Loading

Verified passed with

Brave 0.55.14 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Mac OS X

Verification Passed on

Brave 0.55.14 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Linux

image

Verification passed on

Brave 0.55.14 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Windows 7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
audit-release QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes security
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Show download item origin URL. brave/brave-core
7 participants
@diracdeltas @bbondy @bsclifton @srirambv @LaurenWags @btlechowski @mkarolin