Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave icon in About Brave looks blurry at high DPI and has a blue border around it #1316

Closed
srirambv opened this issue Sep 27, 2018 · 4 comments
Assignees
Labels
feature/brave-pages misc/icons OS/Linux priority/P3 The next thing for us to work on. It'll ride the trains.

Comments

@srirambv
Copy link
Contributor

Description

Brave icon in About Brave looks blurry at high DPI and has a blue border around it

Steps to Reproduce

  1. Install Brave beta on Linux
  2. Visit About Brave from hamburger menu or navigating to chrome://settings/help
  3. Icon has a blue border around it and looks pixelated at 200% DPI

Actual result:

At 100% DPI on Ubuntu
image
At 200% DPI
image
App icon in general looks clear
image

Expected result:

Should not be pixelated and should not have the blue border around it

Reproduces how often:

Easy on Beta build

Brave version (chrome://version info)

Reproducible on current release:

N/A

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@srirambv srirambv added this to the 1.0 (0.56.x) milestone Sep 27, 2018
@rossmoody
Copy link
Contributor

I'd like to investigate this but I don't have access to a Linux machine and I think it might be a styling reaction in the browser via CSS/Javascript going on here. For instance there is an easter egg related to that icon that triggers a spin if you click it. I have a hunch it's reacting poorly in some way on Linux machines. Any way to do a quick double check and just make sure there isn't some weird CSS styling reaction going on here? The pixelation makes sense. It's being served as a 32x32px png.

@rossmoody rossmoody self-assigned this Sep 28, 2018
@srirambv
Copy link
Contributor Author

srirambv commented Oct 9, 2018

The icon on the welcome screen also seems to have the border on Linux. This is only happening on the desktop and not on the VM
image

@srirambv
Copy link
Contributor Author

srirambv commented Oct 9, 2018

image

@rebron rebron modified the milestones: 1.0, 0.56.x - Beta Oct 16, 2018
@rebron rebron removed this from the 0.56.x - Beta milestone Oct 30, 2018
@bbondy bbondy added this to the 1.x Backlog milestone Oct 30, 2018
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Oct 30, 2018
@srirambv
Copy link
Contributor Author

This seems to be fixed on latest release build and on beta.
screenshot from 2018-12-26 07-15-50

@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, 0.58.x - Release Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/brave-pages misc/icons OS/Linux priority/P3 The next thing for us to work on. It'll ride the trains.
Projects
None yet
Development

No branches or pull requests

5 participants