-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Privacy report color issue on dark theme #13455
Labels
feature/new-tab
OS/Android
Fixes related to Android browser functionality
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass - Android ARM
QA Pass - Android Tab
QA/Yes
release-notes/include
Milestone
Comments
srirambv
added
feature/new-tab
needs-more-info
The report requires more detail before we can decide what to do with this issue.
labels
Jan 12, 2021
The browser's theme is set to dark manually, while the OS theme is set to light. If I set the browser's theme to follow the OS theme then it works as expected. Sorry for this omission in my description; updating now. |
anthonypkeane
added
the
priority/P3
The next thing for us to work on. It'll ride the trains.
label
Apr 7, 2021
24 tasks
stephendonner
added
QA Pass - Android ARM
and removed
needs-more-info
The report requires more detail before we can decide what to do with this issue.
labels
May 5, 2021
This was referenced May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature/new-tab
OS/Android
Fixes related to Android browser functionality
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass - Android ARM
QA Pass - Android Tab
QA/Yes
release-notes/include
Description
When opening Privacy Report panel with dark theme enabled (browser's theme se to dark manually while the OS theme is set to light), the color of the blocked trackers/ads list is dark on dark background, therefore not readable.
Steps to reproduce
Actual result
The color of the trackers/ads list is dark on a dark background.
Expected result
The color of the trackers/ads list should be light to have adequate contrast with the dark background.
Issue reproduces how often
Always
Version/Channel Information:
Device details
Brave version
Additional information
To reproduce the issue, the Privacy Report must be enabled in Settings and Privacy Stats must be enabled on the widget that sits on the New Tab Page.
The text was updated successfully, but these errors were encountered: