-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Public content settings are not inherited by private window #1373
Labels
bug
feature/private-browsing
feature/shields
The overall Shields feature in Brave.
priority/P4
Planned work. We expect to get to it "soon".
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/include
Milestone
Comments
bsclifton
added
bug
feature/shields
The overall Shields feature in Brave.
feature/private-browsing
labels
Oct 1, 2018
cc: @bbondy for triage (I picked 1.0, but we may want to fix before then) |
18 tasks
Verified passed with
Verification passed on
Verification passed on
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
feature/private-browsing
feature/shields
The overall Shields feature in Brave.
priority/P4
Planned work. We expect to get to it "soon".
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/include
Description
Public content settings are not inherited by private window. I believe these values are initialized with https://github.com/brave/brave-core/blob/master/components/content_settings/core/browser/brave_host_content_settings_map.cc, but because the extension has it's
incognito
property set tosplit
, it may not be able to directly access theregular
scoped content_settings. More investigation is neededProblem was exposed when fixing #1198
Per #1721 - if no public settings exist for a given site, private window should inherit the global setting
Steps to Reproduce
Private window inheriting from existing public content setting
Private window inheriting from global settings
Actual result:
Expected result:
Shields should be DOWN in the private window... because the session content_settings should inherit from the regular content_settings
Reproduces how often:
100%
Brave version (chrome://version info)
Current master (brave/brave-core@cacede9)
The text was updated successfully, but these errors were encountered: