Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings sidebar doesn't have shortcuts for Sync, New Tab Page, Shields, and Social Media Blocking in 1.22.x #14062

Closed
GeetaSarvadnya opened this issue Feb 9, 2021 · 1 comment · Fixed by brave/brave-core#7895

Comments

@GeetaSarvadnya
Copy link

Description

Settings sidebar doesn't have shortcuts for Sync, New Tab Page, Shields, and Social Media Blocking in 1.22.x

Steps to Reproduce

  1. Clean or upgraded profile 1.22.x
  2. Navigate to brave://settings
  3. Settings sidebar doesn't have shortcuts for Sync, New Tab Page, Shields, and Social Media Blocking in 1.22.x

Actual result:

Settings sidebar doesn't have shortcuts for Sync, New Tab Page, Shields, and Social Media Blocking in 1.22.x
image (9)

Expected result:

Settings sidebar should have shortcuts for Sync, New Tab Page, Shields, and Social Media Blocking in 1.22.x

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.22.9 Chromium: 89.0.4389.40 (Official Build) nightly (64-bit)
Revision 2c2ed83cd507b23e4845edd09a7d1dfc727daf4b-refs/branch-heads/4389@{#602}
OS Windows 10 OS Version 2004 (Build 19041.746)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @rebron @bbondy

@stephendonner
Copy link

Verified FIXED in nightly using the testplan from brave/brave-core#7895 with

Brave 1.22.34 Chromium: 89.0.4389.48 (Official Build) nightly (x86_64)
Revision 0fe3c4589a6cf5ce719d167834dfa9cd8978937a-refs/branch-heads/4389@{#873}
OS macOS Version 11.2.1 (Build 20D74)

Steps:

  1. made sure the Settings sections are back from Settings sidebar doesn't have shortcuts for Sync, New Tab Page, Shields, and Social Media Blocking in 1.22.x #14062
  2. made sure the crypto wallets (brave://settings/wallet) settings still work
  3. made sure things are ordered correctly:
    New Tab Page
    Sync
    Shields
    Social media blocking
    ...
    Wallet Settings (sic)

Screen Shot 2021-02-18 at 2 59 36 PM

Screen Shot 2021-02-18 at 2 59 46 PM

  1. checked both dark and light themes

Screen Shot 2021-02-18 at 2 39 48 PM

Screen Shot 2021-02-18 at 2 54 54 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment