Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BAP popup and alert need Japanese translations #14117

Closed
LaurenWags opened this issue Feb 11, 2021 · 7 comments
Closed

BAP popup and alert need Japanese translations #14117

LaurenWags opened this issue Feb 11, 2021 · 7 comments

Comments

@LaurenWags
Copy link
Member

Description

Found while testing brave/brave-core#7698

The BAP popup and alert display in English even if the OS language is Japanese.

Steps to Reproduce

  1. Have OS set to Japan/Japanese
  2. Trigger BAP popup and/or BAP alert

Actual result:

English text for both:
J4
J5

Expected result:

Japanese translations for that text

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.22.19 Chromium: 89.0.4389.40 (Official Build) nightly (x86_64)
変更履歴 2c2ed83cd507b23e4845edd09a7d1dfc727daf4b-refs/branch-heads/4389@{#602}
OS macOS バージョン10.15.7(ビルド19H512)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @zenparsing @bsclifton @Miyayes @brave/legacy_qa

@LaurenWags
Copy link
Member Author

Android also needs translations. Below screenshots are from 1.22.22:

Tooltip Modal
tooltip-portrait modal-portrait

@Miyayes
Copy link
Collaborator

Miyayes commented Feb 12, 2021

@deeppandya If language is Japanese, these are the translated strings:

Little Tooltip

Brave Rewards in Japan is switching to a new system! Please use your BAP by March 13th. After that, BAP will be discontinued.

[Learn more]

日本でのBrave Rewardsが新システムに移行します!
お持ちのBATポイント(BAP)は、3月13日までにご使用ください。BAPはそれ以降に廃止されます。

[詳しくはこちら]

Full dialog box:

Brave Rewards in Japan is switching to a new system!

The tipping feature will be unavailable from March 13th until April 13th. All BAPs will be discontinued by April 13th. Please use your BAP by March 13th. Any BAP remaining in your Brave browser after March 13th cannot be held or transferred by you or Brave, and will be lost.

A new and improved system awaits!

日本でのBrave Rewardsが新システムに移行します!

3月13日から4月13日チップを送る機能が停止されます。すべてのBATポイント(BAP)は4月13日に廃止されます。
お持ちのBAPは、3月13日までにご使用ください。3月13日以降にBraveブラウザ上に残っているBAPについては、ユーザーもBraveも保持・移転をできず、消失されます。

改良された新システムへの移行をご期待ください!

@kjozwiak
Copy link
Member

Closing as brave/brave-core#7949 was merged into 1.21.x

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Feb 17, 2021

Verification passed on

Brave	1.20.104 Chromium: 88.0.4324.152 (Official Build) (64 ビット)
変更履歴	6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS	Windows 10 OS Version 1809 (Build 17763.1637)
  • Verified the STR from the description.
    image
    image

Verification passed on

Brave 1.20.104 Chromium: 88.0.4324.152 (Official Build) (64-bit)
Revision 6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS Ubuntu 18.04 LTS
  • Verified the STR from the description.
    image
    image

Verified FIXED on

Brave 1.20.104 Chromium: 88.0.4324.152 (Official Build) (x86_64)
変更履歴 6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS macOS バージョン11.2.1(ビルド20D74)

スクリーンショット 2021-02-17 10 32 42

スクリーンショット 2021-02-17 10 41 14

@srirambv srirambv removed the OS/Android Fixes related to Android browser functionality label Feb 17, 2021
@srirambv
Copy link
Contributor

Removing OS/Android label and logged Android specific issue #14220 since the translations are not pulled into Android.

@kjozwiak
Copy link
Member

Moving this into 1.22.x as the BAP work is being reverted via brave/brave-core#8088. Once we have more information next week, we'll re-revert brave/brave-core#8088 and move everything back into 1.21.x and release 1.21.x - Release #2.

@kjozwiak
Copy link
Member

kjozwiak commented Mar 11, 2021

Verification PASSED on Win 10 x64 using the following build:

Brave | 1.21.76 Chromium: 89.0.4389.86 (Official Build) (64-bit)
-- | --
Revision | 0c2dac31bc21e806a791641316e99920f84ea52c-refs/branch-heads/4389@{#1472}
OS | Windows 10 OS Version 2009 (Build 19042.844)

Verified passed with

Brave	1.21.76 Chromium: 89.0.4389.86 (Official Build) (x86_64)
Revision	0c2dac31bc21e806a791641316e99920f84ea52c-refs/branch-heads/4389@{#1472}
OS	macOS Version 10.15.7 (Build 19H524)

Verification passed on

Brave 1.21.76 Chromium: 89.0.4389.86 (Official Build) (64-bit)
Revision 0c2dac31bc21e806a791641316e99920f84ea52c-refs/branch-heads/4389@{#1472}
OS Ubuntu 18.04 LTS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment