Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First run dialog is not translated #14163

Closed
btlechowski opened this issue Feb 15, 2021 · 3 comments
Closed

First run dialog is not translated #14163

btlechowski opened this issue Feb 15, 2021 · 3 comments

Comments

@btlechowski
Copy link

Follow up to #12679

Steps to Reproduce

  1. Clean install
  2. Run Brave in Polish locale

Actual result:

Some strings are not translated
image

Expected result:

All strings are translated

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.21.52 Chromium: 88.0.4324.152 (Official Build) dev (64-bit)
Revision 6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS Ubuntu 18.04 LTS
Brave 1.22.23 Chromium: 89.0.4389.48 (Official Build) nightly (64-bit)
Revision 0fe3c4589a6cf5ce719d167834dfa9cd8978937a-refs/branch-heads/4389@{#873}
OS Ubuntu 18.04 LTS

cc @brave/legacy_qa @rebron @mkarolin

@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Feb 16, 2021
@karenkliu
Copy link

We need to use this text from #14183 for translations

@kjozwiak
Copy link
Member

kjozwiak commented Mar 2, 2021

As per #14369 (comment), moving issue into https://github.com/brave/brave-browser/milestone/167 now that brave/brave-core#8093 was merged into 1.22.x and 1.21.x via brave/brave-core#8096 & brave/brave-core#8097.

@brave/legacy_qa if it's still an issue, please re-open and remove it from the milestone as there was no code associated with the issues so we can just re-open then and decide if it's release blocking or not.

@kjozwiak kjozwiak added this to the 1.21.x - Release milestone Mar 2, 2021
@kjozwiak kjozwiak closed this as completed Mar 2, 2021
@btlechowski
Copy link
Author

btlechowski commented Mar 2, 2021

Verification passed on

Brave 1.21.71 Chromium: 89.0.4389.72 (Official Build) (64-bit)
Revision 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS Ubuntu 18.04 LTS

Polish PL locale
image


Verified passed with

Brave | 1.21.71 Chromium: 89.0.4389.72 (Official Build) (x86_64)
-- | --
Revision | 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS | macOS Version 10.15.7 (Build 19H512)

Verified STR from description for the below languages/locales:

German (Germany) French (France) Japanese (Japan)
German French Japanese

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants