Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting a new default SE from onboarding shows Nothing to see here for favourites on NTP image #14662

Closed
srirambv opened this issue Mar 12, 2021 · 1 comment · Fixed by brave/brave-core#8241

Comments

@srirambv
Copy link
Contributor

Description

Selecting a new default SE from onboarding shows Nothing to see here for favourites on NTP image

Steps to reproduce

  1. Clean install the app
  2. Do not reload NTP after install so favourites list is empty
  3. Click on URL bar to trigger SE onboarding
  4. Change default SE to something else and close
  5. NTP shows Nothing to show here message on NTP image

Actual result

Android.NTP.favourite.message.mp4

Expected result

Should not show the message as widget is already handling it

Issue reproduces how often

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86):ARM
  • Device type (Phone, Tablet, Phablet):All
  • Android version:10

Brave version

GPS version

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @deeppandya

@srirambv
Copy link
Contributor Author

Verification passed on OnePlus 6T with Android 10 running 1.25.51 x64 Beta Build

  • Verified steps from issue description
  • Verified no placeholder message is shown on NTP
Android.ARM.mp4

Verification passed on OnePlus 6T with Android 10 running 1.25.51 x64 Beta Build

  • Verified steps from issue description
  • Verified no placeholder message is shown on NTP
Android.Tab.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants