Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security] [hackerone] wayback machine callback #14991

Closed
simonhong opened this issue Mar 29, 2021 · 1 comment · Fixed by brave/brave-core#8376
Closed

[Security] [hackerone] wayback machine callback #14991

simonhong opened this issue Mar 29, 2021 · 1 comment · Fixed by brave/brave-core#8376
Assignees
@simonhong
Labels
OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include security
Milestone
1.24.x - Release

Comments

@simonhong
Copy link
Member

https://hackerone.com/reports/1139284

cc: @diracdeltas
@simonhong simonhong added security priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes OS/Desktop labels Mar 29, 2021
@simonhong simonhong self-assigned this Mar 29, 2021
simonhong added a commit to brave/brave-core that referenced this issue Mar 29, 2021
@simonhong
Get latest saved page always from wayback machine by invalidating cal…
c70a012 
…lback params

fix brave/brave-browser#14991
@simonhong simonhong mentioned this issue Mar 29, 2021
Merged
24 tasks
@simonhong simonhong added this to the 1.24.x - Nightly milestone Mar 31, 2021
@stephendonner
Copy link

stephendonner commented Apr 7, 2021 •
edited by GeetaSarvadnya
Loading

Verified PASSED using the testplan in brave/brave-core#8376 on build

Brave 1.24.53 Chromium: 90.0.4430.51 (Official Build) nightly (x86_64)
Revision 32e5fa33a31641bded70a90e60121060691e7125-refs/branch-heads/4430@{#927}
OS macOS Version 11.2.3 (Build 20D91)

wayback

(Verified I could reproduce the problem on

Brave 1.23.66 Chromium: 89.0.4389.114 (Official Build) beta (x86_64)
Revision 1ea76e193b4fadb723bfea2a19a66c93a1bc0ca6-refs/branch-heads/4389@{#1616}
OS macOS Version 11.2.3 (Build 20D91))

wayback-beta

Verification passed on

Brave 1.24.66 Chromium: 90.0.4430.72 (Official Build) beta (64-bit)
Revision b6172ef8d07ef486489a4b11b66b2eaeed50d132-refs/branch-heads/4430@{#1233}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#8376
14991

Verification passed on

Brave | 1.24.69 Chromium: 90.0.4430.72 (Official Build) dev (64-bit)
-- | --
Revision | b6172ef8d07ef486489a4b11b66b2eaeed50d132-refs/branch-heads/4430@{#1233}
OS | Windows 10 OS Version 2004 (Build 19041.928)

wayback machine

@LaurenWags LaurenWags changed the title [hackerone] wayback machine callback [Security] [hackerone] wayback machine callback May 4, 2021
@LaurenWags LaurenWags mentioned this issue May 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include security
Projects
None yet
Milestone
1.24.x - Release
Development

Successfully merging a pull request may close this issue.

Get latest saved page always from wayback machine by invalidating callback params brave/brave-core
5 participants
@stephendonner @simonhong @LaurenWags @btlechowski @GeetaSarvadnya