Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify wallet panel appears on Rewards onboarding tour #15194

Closed
zenparsing opened this issue Apr 8, 2021 · 1 comment · Fixed by brave/brave-core#8484
Closed

Verify wallet panel appears on Rewards onboarding tour #15194

zenparsing opened this issue Apr 8, 2021 · 1 comment · Fixed by brave/brave-core#8484

Comments

@zenparsing
Copy link

Description

The verify wallet panel is currently appearing in the rewards onboarding tour even when the bF feature flag disabled.

Steps to Reproduce

  1. Open browser with a clean JP profile using the rewards staging
  2. Open the rewards panel
  3. Click "Start using Brave Rewards"
  4. Navigate through onboarding tour

Actual result:

The verify wallet panel is displayed after the last tour step.

Expected result:

The verify wallet panel should not be displayed.

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes
@stephendonner
Copy link

stephendonner commented Apr 15, 2021

Verified PASSED using

Brave 1.25.19 Chromium: 90.0.4430.72 (Official Build) nightly (x86_64)
変更履歴 b6172ef8d07ef486489a4b11b66b2eaeed50d132-refs/branch-heads/4430@{#1233}
OS macOS バージョン11.2.3(ビルド20D91)

Steps:

  1. changed OS region and language to Japan and Japanese, respectively
  2. clean profile in Brave
  3. launched Brave using --enable-logging=stderr --vmodule="*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true,reconcile-interval=4
  4. clicked on the BAT icon
  5. navigated through the Rewards-onboarding tour

Confirmed I didn't see the bitFlyer slide tacked on to the end, as I did in #14693.

スクリーンショット 2021-04-15 16 23 34

no-last-slide


Verification PASSED on Win 10 x64 using the following build:

Brave | 1.25.24 Chromium: 90.0.4430.72 (Official Build) nightly (64-bit)
-- | --
Revision | b6172ef8d07ef486489a4b11b66b2eaeed50d132-refs/branch-heads/4430@{#1233}
OS | Windows 10 OS Version 2009 (Build 19042.928)

Ran through the second case as per brave/brave-core#8484 (comment) and ensured that the verification modal was being displayed when the BitFlyer feature flag was enabled as per the following:

Using Japan Locale

Example Example
スクリーンショット 2021-04-19 134615 スクリーンショット 2021-04-19 134642

Using English Local (but still using Japan as the region)

Example Example
Screenshot 2021-04-19 134829 Screenshot 2021-04-19 134839

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment