Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Support Unstoppable Domains via Ethereum #15373

Closed
yrliou opened this issue Apr 19, 2021 · 2 comments · Fixed by brave/brave-core#8520
Closed

[Android] Support Unstoppable Domains via Ethereum #15373

yrliou opened this issue Apr 19, 2021 · 2 comments · Fixed by brave/brave-core#8520
Assignees
@yrliou
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.25.x - Release

Comments

@yrliou
Copy link
Member

yrliou commented Apr 19, 2021 •
edited
Loading

Support resolving domains with IPFS records via Ethereum network.

Test Plan:

  1. Go to settings ->Privacy & Security -> Unstoppable Domains, set to Ethereum
  2. Visit brave.crypto, the page should be redirected and loaded via IPFS public gateway.
@yrliou yrliou added the OS/Android Fixes related to Android browser functionality label Apr 19, 2021
@yrliou yrliou self-assigned this Apr 19, 2021
This was referenced Apr 19, 2021
Closed
Merged
@yrliou
Copy link
Member Author

yrliou commented Apr 19, 2021 •
edited
Loading

Fixed by brave/brave-core#8520

@yrliou yrliou closed this as completed Apr 19, 2021
@yrliou yrliou added this to the 1.25.x - Nightly milestone Apr 19, 2021
@stephendonner
Copy link

stephendonner commented May 5, 2021 •
edited by srirambv
Loading

Verified PASSED on Android 9.0 using a Google Pixel, arm64, on Brave 1.25.51, Chromium 90.0.4430.93

Steps:

  1. Went to Settings > Privacy & Security > Unstoppable Domains and chose Ethereum under Resolve Method
  2. Loaded brave.crypto, and confirmed the page loaded as https://bafybeid6rntsjiydicxj5cnmnqonbvwv35lrjgd6dngskptra3oa2otxxm.ipfs.dweb.link/ without issue
example example
Screenshot_20210505-143619 Screenshot_20210505-143647

Verification passed on Samsung Tab A with Android 10 running 1.25.51 x64 build

  • Verified Ethereum is listed as an option for Unstoppable Domains
  • Verified visiting brave.crypto loads the page using IPFS public gateway
image image

This was referenced May 27, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yrliou yrliou

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.25.x - Release
Development

Successfully merging a pull request may close this issue.

Enable support of Unstoppable Domains and ENS on Android brave/brave-core
4 participants
@stephendonner @kjozwiak @yrliou @srirambv