Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Startpage icon #15515

Closed
bsclifton opened this issue Apr 27, 2021 · 1 comment · Fixed by brave/brave-core#8656
Closed

Update Startpage icon #15515

bsclifton opened this issue Apr 27, 2021 · 1 comment · Fixed by brave/brave-core#8656
Assignees
@bsclifton
Labels
OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.25.x - Release

Comments

@bsclifton
Copy link
Member

bsclifton commented Apr 27, 2021 •
edited
Loading

Test plan

See brave/brave-core#8656

Description:

We reference Startpage during onboarding and also in our settings. They have provided us with a new icon

Actual result:
image
https://github.com/brave/brave-core/blob/master/android/java/res/drawable-hdpi/search_engine_startpage.png
https://github.com/brave/brave-core/blob/master/android/java/res/drawable-xhdpi/search_engine_startpage.png
https://github.com/brave/brave-core/blob/master/android/java/res/drawable-xxhdpi/search_engine_startpage.png

Expected result:
image

Additional Information

Updated images per @jamesmudgett
startpage-android.zip
@bsclifton bsclifton added the OS/Android Fixes related to Android browser functionality label Apr 27, 2021
@bsclifton bsclifton mentioned this issue Apr 27, 2021
Merged
24 tasks
bsclifton added a commit to brave/brave-core that referenced this issue Apr 27, 2021
@bsclifton
Update Startpage icons
3c383ca 
Fixes brave/brave-browser#15515
@bsclifton bsclifton self-assigned this Apr 27, 2021
@bsclifton bsclifton added this to the 1.25.x - Nightly milestone Apr 27, 2021
@deeppandya deeppandya mentioned this issue May 10, 2021
Merged
7 tasks
@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.25.60 x64 Beta Build

  • Verified icon is shown properly
Android.ARM.Stargpage.mp4

Verification passed on Samsung Tab A with Android 10 running 1.25.60 x64 Beta Build

  • Verified icon is shown properly
Android.Tab.Startpage.mp4

This was referenced May 27, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bsclifton bsclifton

Labels
OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.25.x - Release
Development

Successfully merging a pull request may close this issue.

Update Startpage icons brave/brave-core
2 participants
@bsclifton @srirambv