Change permissions lifetime UI to make relationship between "block" and the dropdown clearer #15603

pes10k · 2021-05-04T00:07:57Z

The current permissions dialog is unclear about how the "block" button interacts with the times in the dropdown.

@karenkliu suggested one of the attached, with both look 👍 to me

Note That while updating the designs, please also make sure the "until i close this page" text is changed to "until i close this site”/

Related feedback and suggestion from @bridiver #14127 (comment)

@karenkliu I got this permission prompt for the first time and was really confused by it. I showed it to @bbondy and he assumed "Forever" was a mistake. I definitely don't feel like it's clear that the dropdown only applies to "Allow", but until @pes10k pointed me to this ticket (I didn't find anything in the original #14126) I had no idea if the @bbondy was right or if "Forever" was correct and the UI was just confusing.

kjozwiak · 2021-05-10T17:37:36Z

Moving this back into the 1.26.x milestone as this isn't release/blocking and landed in master only which is 1.26.x. Once this is uplifted via brave/brave-core#8733, it will be moved into the 1.25.x milestone.

srirambv · 2021-05-12T09:48:16Z

Verification passed on Samsung Tab A with Android 10 running 1.25.57 x64 Beta Build

Verified "until i close this page" text is changed to "until i close this site”

Allow Tests

5 seconds

Verified passing command line args --permission-lifetime-test-seconds=5 adds an entry to the permission popup
Verified selecting 5 seconds and selecting Allow sets the permission for the page
Verified clicking site info shows permission that is set to allow
Verified after 5 secs the permission is removed and not showed under site details

until I close this site

Verified selecting location and until I close this site and selecting allow sets permission on the site
Verified clicking site info shows permission that is set to allow
Verified opening a new tab and loading the same site still shows the permission set to allow
Verified closing the second tab from pervious step doesn't reset permission on the first tab
Verified when all tabs for the site is closed and reopened in a new tab prompts for permission again

for 24 hours

Verified selecting location and for 24 hours and selecting allow sets permission on the site
Verified clicking site info shows permission that is set to allow
Verified moving device time ahead by 23 hrs and loading the page again and selecting location doesn't prompt for permission
Verified moving device time ahead by 25 hrs and loading the page again and selecting location does prompt for permission

for 1 week

Verified selecting location and for 1 week and selecting allow sets permission on the site
Verified clicking site info shows permission that is set to allow
Verified moving device time ahead by 6 days and loading the page again and selecting location doesn't prompt for permission
Verified moving device time ahead by 8 days and loading the page again and selecting location does prompt for permission

forever

Verified selecting location and forever and selecting allow sets permission on the site
Verified clicking site info shows permission that is set to allow
Verified moving device time ahead by 2 weeks and loading the page again and selecting location doesn't prompt for permission
Verified moving device time ahead by 2 months and loading the page again and selecting location doesn'the prompt for permission

Block Tests

5 seconds

Verified passing command line args --permission-lifetime-test-seconds=5 adds an entry to the permission popup
Verified selecting 5 seconds and selecting Block sets the permission for the page
Verified clicking site info shows permission that is set to block
Verified after 5 secs the permission is removed and not showed under site details

until I close this site

Verified selecting location and until I close this site and selecting block sets permission on the site
Verified clicking site info shows permission that is set to block
Verified opening a new tab and loading the same site still shows the permission set to block
Verified closing the second tab from pervious step doesn't reset permission on the first tab
Verified when all tabs for the site is closed and reopened in a new tab prompts for permission again

for 24 hours

Verified selecting location and for 24 hours and selecting block sets permission on the site
Verified clicking site info shows permission that is set to block
Verified moving device time ahead by 23 hrs and loading the page again and selecting location doesn't prompt for permission
Verified moving device time ahead by 25 hrs and loading the page again and selecting location does prompt for permission

for 1 week

Verified selecting location and for 1 week and selecting block sets permission on the site
Verified clicking site info shows permission that is set to block
Verified moving device time ahead by 6 days and loading the page again and selecting location doesn't prompt for permission
Verified moving device time ahead by 8 days and loading the page again and selecting location does prompt for permission

forever

Verified selecting location and forever and selecting block sets permission on the site
Verified clicking site info shows permission that is set to block
Verified moving device time ahead by 2 weeks and loading the page again and selecting location doesn't prompt for permission
Verified moving device time ahead by 2 months and loading the page again and selecting location doesn'the prompt for permission

Verification passed on OnePlus 6T with Android 10 running 1.25.57 x64 Beta Build

Verified "until i close this page" text is changed to "until i close this site”

Allow Tests

5 seconds

Verified passing command line args --permission-lifetime-test-seconds=5 adds an entry to the permission popup
Verified selecting 5 seconds and selecting Allow sets the permission for the page
Verified clicking site info shows permission that is set to allow
Verified after 5 secs the permission is removed and not showed under site details

until I close this site

Verified selecting location and until I close this site and selecting allow sets permission on the site
Verified clicking site info shows permission that is set to allow
Verified opening a new tab and loading the same site still shows the permission set to allow
Verified closing the second tab from pervious step doesn't reset permission on the first tab
Verified when all tabs for the site is closed and reopened in a new tab prompts for permission again

for 24 hours

Verified selecting location and for 24 hours and selecting allow sets permission on the site
Verified clicking site info shows permission that is set to allow
Verified moving device time ahead by 23 hrs and loading the page again and selecting location doesn't prompt for permission
Verified moving device time ahead by 25 hrs and loading the page again and selecting location does prompt for permission

for 1 week

Verified selecting location and for 1 week and selecting allow sets permission on the site
Verified clicking site info shows permission that is set to allow
Verified moving device time ahead by 6 days and loading the page again and selecting location doesn't prompt for permission
Verified moving device time ahead by 8 days and loading the page again and selecting location does prompt for permission

forever

Verified selecting location and forever and selecting allow sets permission on the site
Verified clicking site info shows permission that is set to allow
Verified moving device time ahead by 2 weeks and loading the page again and selecting location doesn't prompt for permission
Verified moving device time ahead by 2 months and loading the page again and selecting location doesn'the prompt for permission

Block Tests

5 seconds

Verified passing command line args --permission-lifetime-test-seconds=5 adds an entry to the permission popup
Verified selecting 5 seconds and selecting Block sets the permission for the page
Verified clicking site info shows permission that is set to block
Verified after 5 secs the permission is removed and not showed under site details

until I close this site

Verified selecting location and until I close this site and selecting block sets permission on the site
Verified clicking site info shows permission that is set to block
Verified opening a new tab and loading the same site still shows the permission set to block
Verified closing the second tab from pervious step doesn't reset permission on the first tab
Verified when all tabs for the site is closed and reopened in a new tab prompts for permission again

for 24 hours

Verified selecting location and for 24 hours and selecting block sets permission on the site
Verified clicking site info shows permission that is set to block
Verified moving device time ahead by 23 hrs and loading the page again and selecting location doesn't prompt for permission
Verified moving device time ahead by 25 hrs and loading the page again and selecting location does prompt for permission

for 1 week

Verified selecting location and for 1 week and selecting block sets permission on the site
Verified clicking site info shows permission that is set to block
Verified moving device time ahead by 6 days and loading the page again and selecting location doesn't prompt for permission
Verified moving device time ahead by 8 days and loading the page again and selecting location does prompt for permission

forever

Verified selecting location and forever and selecting block sets permission on the site
Verified clicking site info shows permission that is set to block
Verified moving device time ahead by 2 weeks and loading the page again and selecting location doesn't prompt for permission
Verified moving device time ahead by 2 months and loading the page again and selecting location doesn'the prompt for permission

stephendonner · 2021-05-17T18:52:39Z

Verification passed on

Brave	1.25.60 Chromium: 90.0.4430.212 (Official Build) beta (x86_64)
Revision	e3cd97fc771b893b7fd1879196d1215b622c2bed-refs/branch-heads/4430@{#1429}
OS	macOS Version 11.3.1 (Build 20E241)

Verified until i close this page text is changed to until i close this site
For all tests, enabled Permission Lifetime via brave://flags

Allow Tests

5 seconds

Verified passing command line args --permission-lifetime-test-seconds=5 adds an entry to the permission popup
Verified selecting 5 seconds and selecting Allow sets the permission for the page
Verified clicking site info shows permission that is set to allow
Verified after 5 secs the permission is removed and not showed under site details

example	example	example

until I close this site

Verified selecting location and until I close this site and selecting allow sets permission on the site
Verified clicking site info shows permission that is set to allow
Verified opening a new tab and loading the same site still shows the permission set to allow
Verified closing the second tab from pervious step doesn't reset permission on the first tab
Verified when all tabs for the site is closed and reopened in a new tab prompts for permission again

for 24 hours

Verified selecting location and for 24 hours and selecting allow sets permission on the site
Verified clicking site info shows permission that is set to allow
Verified moving laptop time ahead by 23 hrs and loading the page again and selecting location doesn't prompt for permission
Verified moving laptop time ahead by 25 hrs and loading the page again and selecting location does prompt for permission

for 1 week

Verified selecting location and for 1 week and selecting allow sets permission on the site
Verified clicking site info shows permission that is set to allow
Verified moving laptop time ahead by 6 days and loading the page again and selecting location doesn't prompt for permission
Verified moving laptop time ahead by 8 days and loading the page again and selecting location does prompt for permission

forever

Verified selecting location and forever and selecting allow sets permission on the site
Verified clicking site info shows permission that is set to allow
Verified moving laptop time ahead by 2 weeks and loading the page again and selecting location doesn't prompt for permission
Verified moving laptop time ahead by 2 months and loading the page again and selecting location doesn'the prompt for permission

Block Tests

5 seconds

Verified passing command line args --permission-lifetime-test-seconds=5 adds an entry to the permission popup
Verified selecting 5 seconds and selecting Block sets the permission for the page
Verified clicking site info shows permission that is set to block
Verified after 5 secs the permission is removed and not showed under site details

example	example	example

until I close this site

Verified selecting location and until I close this site and selecting block sets permission on the site
Verified clicking site info shows permission that is set to block
Verified opening a new tab and loading the same site still shows the permission set to block
Verified closing the second tab from previous step doesn't reset permission on the first tab
Verified when all tabs for the site is closed and reopened in a new tab prompts for permission again

for 24 hours

Verified selecting location and for 24 hours and selecting block sets permission on the site
Verified clicking site info shows permission that is set to block
Verified moving laptop time ahead by 23 hrs and loading the page again and selecting location doesn't prompt for permission
Verified moving laptop time ahead by 25 hrs and loading the page again and selecting location does prompt for permission

for 1 week

Verified selecting location and for 1 week and selecting block sets permission on the site
Verified clicking site info shows permission that is set to block
Verified moving laptop time ahead by 6 days and loading the page again and selecting location doesn't prompt for permission
Verified moving laptop time ahead by 8 days and loading the page again and selecting location does prompt for permission

forever

Verified selecting location and forever and selecting block sets permission on the site
Verified clicking site info shows permission that is set to block
Verified moving laptop time ahead by 2 weeks and loading the page again and selecting location doesn't prompt for permission
Verified moving laptop time ahead by 2 months and loading the page again and selecting location doesn't prompt for permission

pes10k added OS/Android Fixes related to Android browser functionality OS/Desktop feature/user-interface All UI related needs-text-change This change requires some careful wording. privacy/permissions privacy features related to limiting, lifetime or other permissions labels May 4, 2021

pes10k assigned karenkliu and goodov May 4, 2021

goodov added QA/Yes release-notes/exclude labels May 4, 2021

This was referenced May 4, 2021

Support permission lifetime options for "Block" decision. brave/brave-core#8693

Merged

Change permission UI on Desktop to enable / expose "permission until X" ability #14127

Closed

goodov closed this as completed in brave/brave-core#8693 May 6, 2021

goodov modified the milestones: 1.25.x - Beta, 1.26.x - Nightly May 6, 2021

brave-builds mentioned this issue May 6, 2021

Support permission lifetime options for "Block" decision. (uplift to 1.25.x) brave/brave-core#8733

Merged

7 tasks

kjozwiak modified the milestones: 1.25.x - Beta, 1.26.x - Nightly May 10, 2021

kjozwiak modified the milestones: 1.26.x - Nightly, 1.25.x - Beta May 10, 2021

srirambv added QA Pass - Android ARM QA Pass - Android Tab labels May 12, 2021

This was referenced May 14, 2021

Permission lifetime beta brave/brave-variations#34

Merged

Enable PermissionLifetime on beta channel (100%). brave/brave-variations#35

Merged

stephendonner added the QA Pass-macOS label May 17, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change permissions lifetime UI to make relationship between "block" and the dropdown clearer #15603

Change permissions lifetime UI to make relationship between "block" and the dropdown clearer #15603

pes10k commented May 4, 2021 •

edited

Loading

kjozwiak commented May 10, 2021

srirambv commented May 12, 2021

5 seconds

until I close this site

for 24 hours

for 1 week

forever

5 seconds

until I close this site

for 24 hours

for 1 week

forever

5 seconds

until I close this site

for 24 hours

for 1 week

forever

5 seconds

until I close this site

for 24 hours

for 1 week

forever

stephendonner commented May 17, 2021

5 seconds

until I close this site

for 24 hours

for 1 week

forever

5 seconds

until I close this site

for 24 hours

for 1 week

forever

Change permissions lifetime UI to make relationship between "block" and the dropdown clearer #15603

Change permissions lifetime UI to make relationship between "block" and the dropdown clearer #15603

Comments

pes10k commented May 4, 2021 • edited Loading

kjozwiak commented May 10, 2021

srirambv commented May 12, 2021

5 seconds

until I close this site

for 24 hours

for 1 week

forever

5 seconds

until I close this site

for 24 hours

for 1 week

forever

5 seconds

until I close this site

for 24 hours

for 1 week

forever

5 seconds

until I close this site

for 24 hours

for 1 week

forever

stephendonner commented May 17, 2021

5 seconds

until I close this site

for 24 hours

for 1 week

forever

5 seconds

until I close this site

for 24 hours

for 1 week

forever

pes10k commented May 4, 2021 •

edited

Loading