Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPFS-imported Wikipedia page is missing its images #15634

Closed
stephendonner opened this issue May 5, 2021 · 4 comments
Closed

IPFS-imported Wikipedia page is missing its images #15634

stephendonner opened this issue May 5, 2021 · 4 comments

Comments

@stephendonner
Copy link

stephendonner commented May 5, 2021

Description

IPFS-imported Wikipedia page is missing its images.

Found while testing #14770

Steps to Reproduce

  1. load ipns://brantly.eth to get the interstitial IPFS page
  2. click on Use a local node
  3. go to wikipedia.org
  4. right-click the page and choose Import to IPFS > This page from the context menu
  5. you should get a link similar to https://bafybeih7ugvikad7eyqoa4pi6vo7xvbh627eac2oduxxut6etqu7x4mxf4.ipfs.dweb.link/?filename=www.wikipedia.org
  6. look at the resulting page

Actual result:

The IPFS-imported Wikipedia page is missing its images

Screen Shot 2021-05-05 at 9 48 55 AM

Expected result:

Screen Shot 2021-05-05 at 9 44 21 AM

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.25.51 Chromium: 90.0.4430.93 (Official Build) beta (x86_64)
Revision 4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS macOS Version 11.3.1 (Build 20E241)

/cc @spylogsster

@stephendonner
Copy link
Author

Can also confirm:

  1. shows up fine when I share this link via Slack, and open on another machine, but the bottom icons do not (they are also not in the import directory)
  2. the Wikipedia globe image/logo is in the imported directory
example example example
ipfs-wikimedia Screen Shot 2021-05-05 at 9 59 26 AM Screen Shot 2021-05-05 at 9 59 34 AM

@stephendonner
Copy link
Author

Hey @spylogsster - mind taking a look and seeing if we can get a fix for this into 1.25.x, via an uplift?

@spylogsster
Copy link

@stephendonner this is how chromium page saving works, it is tricky to fix, maybe in future

@vadimstruts
Copy link
Collaborator

The IPFS local node and scheme has been deprecated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants