-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bad reference counting and DCHECK in IPFS Extension API #15996
Milestone
Comments
@spylogsster pls take a look |
24 tasks
stephendonner
added
the
QA/In-Progress
Indicates that QA is currently in progress for that particular issue
label
May 27, 2021
Verified
Steps:
Confirmed I didn't crash; reproduced the crash very easily with an earlier I now get
|
stephendonner
added
QA Pass-macOS
and removed
QA/In-Progress
Indicates that QA is currently in progress for that particular issue
labels
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Extension functions in
ipfs_api.h
useUnretained
pointers and manualAddRef()
Release()
that are not actually needed, because functions are refcounted on their own, and can be bound to callbacks as is.Moreover, there is a wrong balance of
AddRef()
andRelease()
somewhere that leads to DCHECK / memleakSTR:
chrome.ipfs.addIpnsKey("123", () => console.log("aaa"))
in consoleThe text was updated successfully, but these errors were encountered: