Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Qwant in new Private Tab pages #1607

Closed
tildelowengrimm opened this issue Oct 16, 2018 · 4 comments
Closed

Support Qwant in new Private Tab pages #1607

tildelowengrimm opened this issue Oct 16, 2018 · 4 comments
Assignees
@cezaraugusto
Labels
feature/private-browsing feature/tor QA/No
Milestone
0.55.x - Release ...

Comments

@tildelowengrimm
Copy link
Contributor

tildelowengrimm commented Oct 16, 2018 •
edited
Loading

Current new tab pages for Private Browsing only show DuckDuckGo graphics. We should also support the case (as with the Qwant) where the default search engine can be used with Tor and in private windows. This covers a gap left by brave/brave-core#646's partial implementation of #1507.
@tildelowengrimm tildelowengrimm added this to the 0.56.x milestone Oct 16, 2018
@riastradh-brave
Copy link
Contributor

We intend to choose between DDG and Qwant by the user's choice of locale/language setting, but apparently that information is not available in the new tab UI implementation. We need to add some mechanism to get at it.

@riastradh-brave riastradh-brave mentioned this issue Oct 16, 2018
Closed
@riastradh-brave
Copy link
Contributor

@simonhong Can you elaborate on what is missing here and what work needs to be done to make it work?

@darkdh darkdh mentioned this issue Oct 16, 2018
Merged
18 tasks
@rebron rebron modified the milestones: 1.0, FROZEN: 0.55.x - Release Oct 16, 2018
@cezaraugusto cezaraugusto mentioned this issue Oct 16, 2018
Merged
@bsclifton bsclifton mentioned this issue Oct 16, 2018
Closed
@petemill
Copy link
Member

Issue to implement better detection for qwant cc @simonhong @bsclifton #1632

@bsclifton
Copy link
Member

Marking as QA/No in favor of testing #1632 instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

Labels
feature/private-browsing feature/tor QA/No
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

No branches or pull requests
7 participants
@tildelowengrimm @petemill @cezaraugusto @bsclifton @rebron @simonhong @riastradh-brave