Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default position for custom Brave ad notifications on Windows #19463

Closed
tmancey opened this issue Nov 15, 2021 · 3 comments · Fixed by brave/brave-core#11102
Closed

Change default position for custom Brave ad notifications on Windows #19463

tmancey opened this issue Nov 15, 2021 · 3 comments · Fixed by brave/brave-core#11102
Assignees
@tmancey
Labels
1_point For Agile sizing enhancement feature/ads OS/Desktop OS/Windows priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Milestone
1.34.x - Release

Comments

@tmancey
Copy link
Contributor

tmancey commented Nov 15, 2021

No description provided.

@tmancey tmancey self-assigned this Nov 15, 2021
@tmancey tmancey added the 1_point For Agile sizing label Nov 15, 2021
@tmancey tmancey mentioned this issue Nov 15, 2021
Merged
24 tasks
@tmancey tmancey added this to the 1.34.x - Nightly milestone Nov 16, 2021
@btlechowski
Copy link

btlechowski commented Dec 16, 2021 •
edited
Loading

Marked QA/Test-All-Platforms to make sure that other platforms did not regress

Verification passed on

Brave 1.34.63 Chromium: 96.0.4664.110 (Official Build) beta (64-bit)
Revision d5ef0e8214bc14c9b5bbf69a1515e431394c62a6-refs/branch-heads/4664@{#1283}
OS Windows 7 Service Pack 1 (Build 7601.24544)

Verified custom ads are shown in the bottom right corner, shifted to the left
Logged #20219

image

Verification passed on

Brave 1.34.63 Chromium: 96.0.4664.110 (Official Build) beta (64-bit)
Revision d5ef0e8214bc14c9b5bbf69a1515e431394c62a6-refs/branch-heads/4664@{#1283}
OS Ubuntu 18.04 LTS

Verified custom ads position did not regress on Linux

image

@stephendonner
Copy link

Verified PASSED using Windows 10:

Brave 1.34.66 Chromium: 96.0.4664.110 (Official Build) beta (64-bit)
Revision d5ef0e8214bc14c9b5bbf69a1515e431394c62a6-refs/branch-heads/4664@{#1283}
OS Windows 10 Version 20H2 (Build 19042.1415)
Custom-ad notification Native/system-ad notification
19463-custom-ads 19463-native-ads

@stephendonner
Copy link

Verified PASSED on

Brave 1.34.68 Chromium: 97.0.4692.56 (Official Build) beta (x86_64)
Revision 04da6c66398ca50e603cc236a07dc7dfd3bbc750-refs/branch-heads/4692@{#990}
OS macOS Version 11.6.1 (Build 20G224)

Verified custom-ad position and notifications didn't regress on macOS.

Screen Shot 2021-12-21 at 1 36 52 PM

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
1_point For Agile sizing enhancement feature/ads OS/Desktop OS/Windows priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.34.x - Release
Development

Successfully merging a pull request may close this issue.

Change default position for custom Brave ad notifications on Windows brave/brave-core
4 participants
@stephendonner @tmancey @LaurenWags @btlechowski