Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when permission requests for Ethereum are from a popup window #19566

Closed
bbondy opened this issue Nov 18, 2021 · 1 comment · Fixed by brave/brave-core#11156
Closed

Fix crash when permission requests for Ethereum are from a popup window #19566

bbondy opened this issue Nov 18, 2021 · 1 comment · Fixed by brave/brave-core#11156
Assignees
@bbondy
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.32.x - Release #2

Comments

@bbondy
Copy link
Member

bbondy commented Nov 18, 2021 •
edited
Loading

Browser crashes on connecting Brave Wallet to https://market.x.immutable.com.
Related bug report: https://community.brave.com/t/brave-wallet-crashing-brave-after-new-update/302976

Test plan

  • Simply go to https://market.x.immutable.com and click on Connect Wallet, the popup window will come up and our popup should come up above it.
  • Note that there's a webcompat item separate from this issue so you won't actually be able to connect to the site.
@bbondy bbondy added priority/P1 A very extremely bad problem. We might push a hotfix for it. feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop labels Nov 18, 2021
@bbondy bbondy self-assigned this Nov 18, 2021
@bbondy bbondy mentioned this issue Nov 18, 2021
Open
@bbondy bbondy mentioned this issue Nov 18, 2021
Merged
24 tasks
@bbondy bbondy added this to the 1.34.x - Nightly milestone Nov 19, 2021
This was referenced Nov 19, 2021
Merged
Merged
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.32.111 Chromium: 96.0.4664.45 (Official Build) (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
  • Verified no crash when trying to connecting wallet
  • Verified test plan from issue description
  • Encountered webcompat issue mentioned in test plan
Linux Windows macOS

@srirambv srirambv mentioned this issue Nov 24, 2021
Closed
9 tasks
@kjozwiak kjozwiak mentioned this issue Nov 25, 2021
Closed
@srirambv srirambv removed the OS/Android Fixes related to Android browser functionality label Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbondy bbondy

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.32.x - Release #2
Development

Successfully merging a pull request may close this issue.

Fix crash with popup windows requesting Ethereum permission brave/brave-core
3 participants
@bbondy @kjozwiak @srirambv