-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only allow expand shields when there are blocked items #1957
Labels
design
A design change, especially one which needs input from the design team
feature/shields/panel
Front-end design and functionality of the Shields panel.
feature/shields
The overall Shields feature in Brave.
priority/P5
Not scheduled. Don't anticipate work on this any time soon.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/include
Milestone
Comments
srirambv
added
feature/shields
The overall Shields feature in Brave.
design
A design change, especially one which needs input from the design team
priority/P5
Not scheduled. Don't anticipate work on this any time soon.
QA/Yes
labels
Nov 1, 2018
tildelowengrimm
added
the
feature/shields/panel
Front-end design and functionality of the Shields panel.
label
Nov 2, 2018
Updated to be 0.58.x after DEPS was updated with brave/brave-core#820 PR is tagged with uplift-request; let's make sure to modify milestone if that is approved 😄 |
Verification Passed on
Verified passed with
Verification passed on
|
bbondy
changed the title
Details view open for 0 blocked items on shields
Only allow expand shields when there are blocked items
Dec 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
design
A design change, especially one which needs input from the design team
feature/shields/panel
Front-end design and functionality of the Shields panel.
feature/shields
The overall Shields feature in Brave.
priority/P5
Not scheduled. Don't anticipate work on this any time soon.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/include
Description
Details view open for 0 blocked items on shields
Steps to Reproduce
0
, opens details view even though there is nothing to showActual result:
Expected result:
Should only change cursor to hand icon when there are blocked items so that the details view can be shown
Reproduces how often:
Easy
Brave version (brave://version info)
Reproducible on current release:
Yes on beta
Website problems only:
Additional Information
Follow up to #507
cc: @karenkliu @tomlowenthal
The text was updated successfully, but these errors were encountered: