-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localization doesn't work in for Brave chrome strings and web-ui pages like brave://welcome and brave://rewards #2035
Labels
Milestone
Comments
bbondy
changed the title
Localization doesn't work in web-ui pages like brave://welcome and brave://rewards
Localization doesn't work in for Brave chrome strings and web-ui pages like brave://welcome and brave://rewards
Nov 7, 2018
bbondy
added a commit
to brave/brave-core
that referenced
this issue
Nov 7, 2018
18 tasks
Verified passed with
Verification passed on
Verification Passed on
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Description
If you change your system language to French or some other language, localization will not show up on web-ui pages.
Steps to Reproduce
Actual result:
In step 2. on the welcome page you'll see no translated strings.
In step 3. you'll also see no translated strings.
Expected result:
Translated strings should show up (note that maybe not all of them will actually show up if we are missing translations, but at least some of them should show up to resolve this issue).
Reproduces how often:
Always.
Brave version (brave://version info)
All but I'm using 0.57.4
Reproducible on current release:
Yes.
Website problems only:
Additional Information
The text was updated successfully, but these errors were encountered: