Upgrade from Chromium 98.0.4758.66 to Chromium 98.0.4758.72.

[mkarolin]

Minor Chromium bump.

https://chromium.googlesource.com/chromium/src/+log/98.0.4758.66..98.0.4758.72?pretty=fuller&n=10000

QA tests:

Check branding items
Check for version bump

Additional checks:

No specific code changes in Brave (only line number changes in patches).

[kjozwiak]

Remaining items:

• Win & Android ARM need to run through the SKU cases as per Upgrade from Chromium 97 to Chromium 98 #19664 (comment)
• macOS & Linux need to run through the areas mentioned via Upgrade from Chromium 97 to Chromium 98 #19664 (comment) and the SKU cases as per Upgrade from Chromium 97 to Chromium 98 #19664 (comment).

cc @brave/legacy_qa ☝🏻

[srirambv]

Verification passed on the following devices running 1.35.97 x64 build

Oppo Reno 5 (Android 11)	Samsung Tab A (Android 10)

Pending Android verification #19664 (comment). Will add Android pass labels once the SKU verification is done

SKU tests verified here #20741 (comment)

[stephendonner]

Verification PASSED on

Brave	1.35.97 Chromium: 98.0.4758.72 (Official Build) (x86_64)
Revision	d63e30f73734c5326037b0d94eceed77168d95e1-refs/branch-heads/4758@{#905}
OS	macOS Version 11.6.1 (Build 20G224)

1. Settings UI:

• Confirmed all the settings are displayed as expected in brave://settings and UI also looks good.
• Confirmed content settings are displayed as expected in brave://settings/content
• Confirmed security settings are as expected, no new settings are added as part of CR 98 in brave://settings/security
• Confirmed brave://settings/searchEngines is displayed as expected no new settings added, the UI looks good
• Confirmed all the settings under brave://settings/extensions are displayed as expected
• Confirmed Share this page options works as expected

Encountered #20750 while testing.

2. Brave News

• Confirmed clicking on Show Brave News shows the Brave News feeds
• Confirmed content cards are loading the images correctly in feeds when the Brave News feed is scrolled down
• Confirmed click on any image/link on news feed redirects to correct target link
• Confirmed images render properly on brave news feeds when any publisher is enabled/disabled via Sources

3. Components updater

Compared brave://components to release

brave://components	release

4. Permissions bubble shows correctly

• Confirmed site settings permissions work as expected

Example	Example	Example	Example

5. Cosmetic filtering

• Cosmetic filtering works as expected
• Element on any page can be blocked via block element selector

element blocked	blocked rule	remove rules	blocked elements reappeared

6. AdBlock regional list

• Encountered the issue Regional adblock filters are not pre-selected based on locale #4367
• Launched browser using --lang=fr and confirmed correct Adblock regional filter is pre-selected in brave://adblock
• Launched browser using --lang=de and confirmed correct Adblock regional filter is pre-selected in brave://adblock

Example	Example

7. Tabs search button toggle in settings works correctly

• Confirmed Tab search option is shown when the Show tab search button settings is enabled
• Confirmed able to search the particular tab from list of tabs
• Confirmed Tab search option isn't shown when the Show tab search button settings is disabled
• Confirmed Show tab search button setting retained after browser restart

Example	Example	Example

8. SKUs

Followed the steps for the two SKU testcases over in brave/brave-core#11985 (comment)

Case 1: Verify SKU functionality is disable on allow-list domains

1. Visit https://account.brave.software and enter basic auth credentials (reach out to @bsclifton for details)
2. Open dev tools (F12, etc) and go to Console tab
3. Paste in: await window.chrome.braveSkus.refresh_order('0ee1e3ee-afc3-4f2f-b2a2-3d1e401e1530') and hit enter. It should show

   Uncaught TypeError: Cannot read properties of undefined (reading 'refresh_order')
   at <anonymous>:1:31
   

4. Steps 1-3 can be repeated on https://account.brave.com or https://account.bravesoftware.com

account.brave.com	account.bravesoftware.com	account.brave.software

Case 2: Verify SKU functionality is disabled on non-allowed domains

1. Visit any non-Brave website
2. Open dev tools (F12, etc) and go to Console tab
3. Paste in: await window.chrome.braveSkus.refresh_order('0ee1e3ee-afc3-4f2f-b2a2-3d1e401e1530') and hit enter. It should show

   Uncaught TypeError: Cannot read properties of undefined (reading 'refresh_order')
   at <anonymous>:1:31
   

[stephendonner]

Verification PASSED on

Brave	1.35.97 Chromium: 98.0.4758.72 (Official Build) (64-bit)
Revision	d63e30f73734c5326037b0d94eceed77168d95e1-refs/branch-heads/4758@{#905}
OS	Linux

1. Settings UI:

• Confirmed all the settings are displayed as expected in brave://settings and UI also looks good.
• Confirmed content settings are displayed as expected in brave://settings/content
• Confirmed security settings are as expected, no new settings are added as part of CR 98 in brave://settings/security
• Confirmed brave://settings/searchEngines is displayed as expected no new settings added, the UI looks good
• Confirmed all the settings under brave://settings/extensions are displayed as expected
• Confirmed Share this page options works as expected

Encountered #20750 while testing.

2. Brave News

• Confirmed clicking on Show Brave News shows the Brave News feeds
• Confirmed content cards are loading the images correctly in feeds when the Brave News feed is scrolled down
• Confirmed click on any image/link on news feed redirects to correct target link
• Confirmed images render properly on brave news feeds when any publisher is enabled/disabled via Sources

3. Components updater

Compared brave://components to release

brave://components	release
	.

4. Permissions bubble shows correctly

• Confirmed site settings permissions work as expected

Example	Example	Example	Example

5. Cosmetic filtering

• Cosmetic filtering works as expected
• Element on any page can be blocked via block element selector

element blocked	blocked rule	remove rules	blocked elements reappeared

6. AdBlock regional list

• Encountered the issue Regional adblock filters are not pre-selected based on locale #4367
• Launched browser using --lang=fr and confirmed correct Adblock regional filter is pre-selected in brave://adblock
• Launched browser using --lang=de and confirmed correct Adblock regional filter is pre-selected in brave://adblock

Example	Example

7. Tabs search button toggle in settings works correctly

• Confirmed Tab search option is shown when the Show tab search button settings is enabled
• Confirmed able to search the particular tab from list of tabs
• Confirmed Tab search option isn't shown when the Show tab search button settings is disabled
• Confirmed Show tab search button setting retained after browser restart

Example	Example	Example

8. SKUs

Followed the steps for the two SKU testcases over in brave/brave-core#11985 (comment)

Case 1: Verify SKU functionality is disable on allow-list domains

1. Visit https://account.brave.software and enter basic auth credentials (reach out to @bsclifton for details)
2. Open dev tools (F12, etc) and go to Console tab
3. Paste in: await window.chrome.braveSkus.refresh_order('0ee1e3ee-afc3-4f2f-b2a2-3d1e401e1530') and hit enter. It should show

   Uncaught TypeError: Cannot read properties of undefined (reading 'refresh_order')
   at <anonymous>:1:31
   

4. Steps 1-3 can be repeated on https://account.brave.com or https://account.bravesoftware.com

account.brave.com	account.bravesoftware.com	account.brave.software

Case 2: Verify SKU functionality is disabled on non-allowed domains

1. Visit any non-Brave website
2. Open dev tools (F12, etc) and go to Console tab
3. Paste in: await window.chrome.braveSkus.refresh_order('0ee1e3ee-afc3-4f2f-b2a2-3d1e401e1530') and hit enter. It should show

   Uncaught TypeError: Cannot read properties of undefined (reading 'refresh_order')
   at <anonymous>:1:31
   

[LaurenWags]

labelling QA/No and release-notes/exclude as this is superseded by #20741