Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to create sync chain without entering a device name #2126

Closed
srirambv opened this issue Nov 14, 2018 · 3 comments · Fixed by brave/brave-core#915
Closed

Unable to create sync chain without entering a device name #2126

srirambv opened this issue Nov 14, 2018 · 3 comments · Fixed by brave/brave-core#915

Comments

@srirambv
Copy link
Contributor

Description

Unable to create sync chain without entering a device name

Steps to Reproduce

  1. Launch browser with --enable-brave-sync
  2. Open brave://sync
  3. Click on I am new to Sync
  4. Click Create Sync button on popup modal, doesn't use the placeholder text to create a sync chain. Only creates after entering a device name

Actual result:

https://youtu.be/shYejuYzzKw

Expected result:

Should be able to user placeholder text to create a sync chain similar to b-l

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.57.6 Chromium: 71.0.3578.31 (Official Build) beta (64-bit)
Revision c88fdf2a4ce19a713615ca4fbde7a0d0b5fe2363-refs/branch-heads/3578@{#427}
OS All

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? Yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@LaurenWags
Copy link
Member

LaurenWags commented Nov 27, 2018

Verified passed with

Brave 0.57.7 Chromium: 71.0.3578.53 (Official Build) beta(64-bit)
Revision 599fb72e740eab9d10609f1ed28a2ad669f82c1a-refs/branch-heads/3578@{#669}
OS Mac OS X
  • Verified STR from description
    screen shot 2018-11-27 at 3 24 34 pm

Verification passed on

Brave 0.57.7 Chromium: 71.0.3578.53 (Official Build) beta(64-bit)
Revision 599fb72e740eab9d10609f1ed28a2ad669f82c1a-refs/branch-heads/3578@{#669}
OS Linux

image

Verification passed on

Brave 0.57.7 Chromium: 71.0.3578.53 (Official Build) beta (64-bit)
Revision 599fb72e740eab9d10609f1ed28a2ad669f82c1a-refs/branch-heads/3578@{#669}
OS Windows
  • Verified the STR mentioned in defect

image

@srirambv
Copy link
Contributor Author

Removed QA pass label. Need to verify it against beta again

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 4, 2018

Verification Passed on

Brave 0.57.12 Chromium: 71.0.3578.75 (Official Build) (64-bit)
Revision 06ef00b5279f93f8e0c1e73acedd49d7dcc09767-refs/branch-heads/3578@{#836}
OS Windows
  • Verified the STR mentioned in issue.
    image

Verification passed on

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta(64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Linux

ezgif com-video-to-gif

Verified passed with

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta(64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Mac OS X
  • Verified STR in issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment