Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device creates a new sync chain when using existing code words #2139

Closed
srirambv opened this issue Nov 14, 2018 · 1 comment · Fixed by brave/brave-core#973
Closed

Device creates a new sync chain when using existing code words #2139

srirambv opened this issue Nov 14, 2018 · 1 comment · Fixed by brave/brave-core#973

Comments

@srirambv
Copy link
Contributor

Description

Device creates a new sync chain when using existing code words

Devices

Device 1: Ubuntu (Sync chain creator)
Device 2: Windows 10 (Also sync chain creator)

Steps to Reproduce

  1. Create sync chain on device 1
  2. Copy code words from device 1
  3. Launch brave with sync parameter on device 2
  4. Select I have an sycn chain code option on device 2
  5. Paste the code words from step 2
  6. Enter device 2 name and click sync, disconnect from network instantly
  7. Reconnect device 2 to network and try sync again, nothing happens (Sync chain creation fails after system comes online #2137)
  8. Relaunch browser, sync chain is created on device 2 as well but doesn't list device 1
  9. Check for code words on device 2, has a new set of code words from device 1

Actual result:

https://youtu.be/_Rp_uH6egYE

Expected result:

Should join existing sync chain when using code words and not create a different sync chain

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.57.6 Chromium: 71.0.3578.31 (Official Build) beta (64-bit)
Revision c88fdf2a4ce19a713615ca4fbde7a0d0b5fe2363-refs/branch-heads/3578@{#427}
OS Windows/Linux

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Yes on beta build

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

cc: @AlexeyBarabash @darkdh @brave/legacy_qa

@srirambv srirambv added this to the 0.57.x - Beta milestone Nov 14, 2018
@darkdh darkdh self-assigned this Nov 21, 2018
@bbondy bbondy removed this from the 0.57.x - Beta milestone Nov 27, 2018
@darkdh darkdh added this to the 0.57.x - Beta milestone Nov 29, 2018
@bbondy bbondy modified the milestones: 0.57.x - Beta, 0.58.x - Dev Nov 29, 2018
@btlechowski
Copy link

btlechowski commented Dec 12, 2018

Verification passed on

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Windows 7 x64

Used STR from OP.

Verified passed with

Brave 0.58.12 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Mac OS X
  • Verified STR from description (Device 1 is macOS, Device 2 is Linux VM)

Verification passed on

Brave 0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Linux

Used STR from OP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants