Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shields shouldn't be available from internal/chrome:// pages #21572

Closed
stephendonner opened this issue Mar 9, 2022 · 1 comment · Fixed by brave/brave-core#12523
Closed
Assignees
Labels
bug feature/global-settings Settings at browser level independent of shields settings feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. OS/Desktop QA Pass-macOS QA/Test-Plan-Specified QA/Yes regression release-notes/exclude

Comments

@stephendonner
Copy link

Description

Shields shouldn't be available from internal/chrome:// pages

Steps to Reproduce

  1. install 1.38.32
  2. launch Brave
  3. load brave://flags
  4. set Enable Brave Shields v2 to Enabled
  5. click to Relaunch Brave
  6. in the same internal brave://flags tab, click on the new Shields icon in the URL bar

Actual result:

You get the Shields doorhanger popup, functional

Screen Shot 2022-03-09 at 11 35 25 AM

Expected result:

Nothing should happen when you click on the Shields icon on internal chrome:// schemes / pages

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.38.32 Chromium: 99.0.4844.51 (Official Build) nightly (x86_64)
Revision d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS macOS Version 11.6.3 (Build 20G415)

Version/Channel Information:

  • Can you reproduce this issue with the current release? no
  • Can you reproduce this issue with the beta channel? no
  • Can you reproduce this issue with the nightly channel? yes

cc @rebron @nullhook @ShivanKaul @pes10k

@stephendonner stephendonner added bug feature/shields The overall Shields feature in Brave. feature/global-settings Settings at browser level independent of shields settings QA/Test-Plan-Specified regression feature/shields/panel Front-end design and functionality of the Shields panel. OS/Desktop QA/Yes labels Mar 9, 2022
@nullhook nullhook self-assigned this Mar 10, 2022
@nullhook nullhook added this to the 1.38.x - Nightly milestone Mar 15, 2022
@stephendonner
Copy link
Author

stephendonner commented Mar 21, 2022

Verified PASSED using

Brave 1.38.60 Chromium: 100.0.4896.46 (Official Build) nightly (x86_64)
Revision 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS macOS Version 11.6.3 (Build 20G415)

Confirmed Shields were disabled on various internal brave:// pages
Confirmed Shields were available by default and blocked content on CNN.com

brave://about brave://rewards brave://flags brave://version
Screen Shot 2022-03-21 at 11 54 19 AM Screen Shot 2022-03-21 at 11 53 05 AM Screen Shot 2022-03-21 at 11 52 39 AM Screen Shot 2022-03-21 at 11 52 51 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/global-settings Settings at browser level independent of shields settings feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. OS/Desktop QA Pass-macOS QA/Test-Plan-Specified QA/Yes regression release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants