Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buy crypto assets UI v2 #21639

Closed
jamesmudgett opened this issue Mar 14, 2022 · 3 comments · Fixed by brave/brave-core#12830 or brave/brave-core#12861
Closed

Buy crypto assets UI v2 #21639

jamesmudgett opened this issue Mar 14, 2022 · 3 comments · Fixed by brave/brave-core#12830 or brave/brave-core#12861
Assignees
@muliswilliam
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.39.x - Release

Comments

@jamesmudgett
Copy link

Improve buy widget to allow for multiple onramp providers.
@jamesmudgett jamesmudgett added design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Mar 14, 2022
@jamesmudgett
Copy link
Author

Screen Shot 2022-03-15 at 8 01 44 AM

@jamesmudgett jamesmudgett mentioned this issue Mar 15, 2022
Closed
@bbondy bbondy added the front-end-change This task is a front end task and doesn't need any C++ changes label Mar 18, 2022
@muliswilliam muliswilliam self-assigned this Mar 25, 2022
@muliswilliam muliswilliam mentioned this issue Mar 30, 2022
Merged
25 tasks
@onyb onyb mentioned this issue Apr 1, 2022
Merged
25 tasks
@onyb onyb added this to the 1.39.x - Nightly milestone Apr 11, 2022
@onyb onyb reopened this Apr 11, 2022
@onyb onyb removed this from the 1.39.x - Nightly milestone Apr 11, 2022
@brave-builds brave-builds mentioned this issue May 12, 2022
Merged
7 tasks
@kjozwiak kjozwiak added QA/Yes release-notes/include and removed design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. labels May 13, 2022
@kjozwiak
Copy link
Member

The above requires 1.39.105 or higher for 1.39.x verification 👍

@srirambv
Copy link
Contributor

Brave 1.39.108 Chromium: 101.0.4951.67 (Official Build) beta (64-bit)
Revision 8888ee7a24e2c36661ddb9536c35b7d4852a3a98-refs/branch-heads/4951@{#1230}
OS ☑️ Linux ☑️ Windows 11 Version 22H2
(Build 22621.1) 		☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from brave/brave-core#12830
  • Verified on Buy tab, there is a drop-down for selecting the purchase network for selected token
  • Verified when a token isn't available on Ramp it automatically defaults to Wyre
  • Verified input value is properly accounted on the landing page and generates the correct purchase value
  • Verified the new provider options work on both widget and panel
21639-Linux.mp4
21639-Windows.mov
21639-macOS.mov

@bbondy bbondy changed the title Buy v2 Buy crypto assets UI v2 May 20, 2022
@LaurenWags LaurenWags mentioned this issue May 23, 2022
Closed
avinassh pushed a commit to avinassh/brave-browser-hardening that referenced this issue May 29, 2022
Brave Browser 1.39.111
6b60f4b 
 - Added Solana support for account creation, sending SOL and sending SPL tokens with Brave Wallet. ([#22348](brave/brave-browser#22348))
 - Added the ability to buy with Ramp using Brave Wallet. ([#21639](brave/brave-browser#21639))
 - Added JSONSanitizer to API helper requests for Brave Wallet. ([#21831](brave/brave-browser#21831))
 - Added Dapp UI for requesting a public key and for decrypting ciphers using Brave Wallet. ([#21177](brave/brave-browser#21177))
 - Added web3_clientVersion support for Brave Wallet. ([#19278](brave/brave-browser#19278))
 - Added the ability to allow users to search sites for RSS feeds for Brave News. ([#21768](brave/brave-browser#21768))
 - Added support for blob partitioning. ([#21746](brave/brave-browser#21746))
 - Added minimum macOS version for Sparkle update process. ([#22918](brave/brave-browser#22918))
 - [Security] Blocked "window.ethereum" completely in third party iframes. ([#22686](brave/brave-browser#22686))
 - [Security] Updated Brave Wallet panel to prominently display eTLD+1 as reported on HackerOne by renekroka. ([#21787](brave/brave-browser#21787))
 - [Security] Fixed incorrect origin being displayed in Brave Wallet when a spend approval is pending. ([#19557](brave/brave-browser#19557))
 - Implemented eth_getEncryptionPublicKey for Brave Wallet. ([#19276](brave/brave-browser#19276))
 - Implemented account discovery when restoring Brave Wallet. ([#18104](brave/brave-browser#18104))
 - Updated Omaha installer version for Windows to v1.3.36.113. ([#22060](brave/brave-browser#22060))
 - Updated default IPFS configuration values. ([#22068](brave/brave-browser#22068))
 - Updated Gas Limit validation and error messaging for unapproved transactions with Brave Wallet. ([#21714](brave/brave-browser#21714))
 - Updated Brave Wallet to automatically add swap taker asset to the visible asset list. ([#21428](brave/brave-browser#21428))
 - Updated Brave Wallet portfolio network filter for multichain support. ([#20780](brave/brave-browser#20780))
 - Reduced adblock filter memory usage by optimizing unused regex rules. ([#21970](brave/brave-browser#21970))
 - Removed known Dialog Insight user tracking parameters from URLs. ([#22082](brave/brave-browser#22082))
 - Removed ability to swap ERC721 tokens with Brave Wallet. ([#21550](brave/brave-browser#21550))
 - Fixed crash which occurred when opening Brave Shields while using Google Meet. ([#22814](brave/brave-browser#22814))
 - Fixed inability to rename Solana account in Brave Wallet after it has been created. ([#22958](brave/brave-browser#22958))
 - Fixed incorrectly computed insufficient funds errors in Brave Wallet. ([#22877](brave/brave-browser#22877))
 - Fixed ERC20 and ERC721 transfers being incorrectly displayed as ETH transfers in the Brave Wallet transactions panel. ([#22044](brave/brave-browser#22044))
 - Fixed text alignment issues under the Brave Wallet "Recent transactions" panel when using long account names. ([#21216](brave/brave-browser#21216))
 - Fixed breakage in webpack build caused by OpenSSL 3.0. ([#22305](brave/brave-browser#22305))
 - Fixed two windows being opened on launch when the browser was installed without administrator privileges on Windows. ([#22179](brave/brave-browser#22179))
 - Upgraded Chromium to 102.0.5005.61. ([#22923](brave/brave-browser#22923)) ([Changelog for 102.0.5005.61](https://chromium.googlesource.com/chromium/src/+log/101.0.4951.67..102.0.5005.61?pretty=fuller&n=1000))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muliswilliam muliswilliam

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.39.x - Release
6 participants
@jamesmudgett @bbondy @kjozwiak @onyb @srirambv @muliswilliam