Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Shields blocked-count tooltip should be multi-line #21943

Closed
stephendonner opened this issue Mar 28, 2022 · 2 comments · Fixed by brave/brave-core#12798
Closed

Brave Shields blocked-count tooltip should be multi-line #21943

stephendonner opened this issue Mar 28, 2022 · 2 comments · Fixed by brave/brave-core#12798

Comments

@stephendonner
Copy link

Description

Brave Shields blocked-count tooltip should be multi-line

Steps to Reproduce

  1. new profile
  2. launch Brave
  3. load cnn.com
  4. hover over the Shields icon
  5. read the tooltip

Actual result:

Tooltip text is a single line; see below

160472514-1ee9ec4c-2b62-40c6-9251-685431f7e503

Expected result:

It should be a multi-line tooltip, per #17369 (comment)

128423351-dc0685f7-e3cf-4fd8-b14f-82aba45a965f

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.39.10 Chromium: 100.0.4896.46 (Official Build) nightly (x86_64)
Revision 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS macOS Version 11.6.5 (Build 20G527)

cc @jenn-rhim @nullhook

@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.39.18 Chromium: 100.0.4896.60 (Official Build) nightly (x86_64)
Revision 6a5d10861ce8de5fce22564658033b43cb7de047-refs/branch-heads/4896@{#875}
OS macOS Version 11.6.5 (Build 20G527)

Screen Shot 2022-03-30 at 12 18 53 PM

@MadhaviSeelam
Copy link

MadhaviSeelam commented Apr 28, 2022

Verification PASSED using

Brave 1.39.83 Chromium: 101.0.4951.41 (Official Build) beta (64-bit)
Revision 93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS Windows 11 Version 21H2 (Build 22000.613)

Verified Brave Shields blocked-count tooltip is multi-line

  • Installed 1.39.83
  • Launch Brave
  • Load cnn.com
  • Hover over the Shields icon
  • Tooltip displayed multi-line

shields

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants