Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings text in the sidebar menu is not translated to other locales #21973

Open
GeetaSarvadnya opened this issue Mar 30, 2022 · 1 comment
Open
Labels
bug feature/sidebar Relating to Brave's Sidebar feature l10n OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/Test-Plan-Specified QA/Yes

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Mar 30, 2022

Description

Found while testing #21963
Settings in the sidebar menu is not translated to other locales

Steps to Reproduce

  1. Set OS locale to Germany/France/Kannada/Hindi
  2. Clean profile 1.37.109
  3. Enable Sidebar settings
  4. Settings in the sidebar menu is not translated to other locales

Actual result:

Settings in the sidebar menu is not translated to other locales

France:
image

Kannada:
image

Expected result:

Settings in the sidebar menu should be translated to other locales

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.37.109 Chromium: 100.0.4896.60 (ಅಧಿಕೃತವಾಗಿ ನಿರ್ಮಿಸಿ) (64-ಬಿಟ್)
ಪರಿಷ್ಕರಣೆ 6a5d10861ce8de5fce22564658033b43cb7de047-refs/branch-heads/4896@{#875}
OS Windows 10 Version 21H2 (Build 19044.1586)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/qa-team @rebron @mkarolin

@GeetaSarvadnya GeetaSarvadnya changed the title Settings in the sidebar menu is not translated to other locales Settings text in the sidebar menu is not translated to other locales Mar 30, 2022
@mkarolin
Copy link
Contributor

@GeetaSarvadnya the item you are seeing there - settings is just the URL part. For example, if you were on cnn.com and pointed to the + button, you would see www.cnn.com.

Perhaps for schemes like brave:// we should be showing the page title rather than the URL part. WDYT, @simonhong @rebron?

@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Apr 5, 2022
@rebron rebron added the feature/sidebar Relating to Brave's Sidebar feature label Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/sidebar Relating to Brave's Sidebar feature l10n OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/Test-Plan-Specified QA/Yes
Projects
Status: P1 & P2 Backlog
Development

No branches or pull requests

3 participants