Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create and automatically publish silent installers for Brave-Core (Windows) #2210

Closed
davidtemkin opened this issue Nov 21, 2018 · 4 comments · Fixed by brave/brave-core#974
Closed

Comments

@davidtemkin
Copy link

Description

In order to support distribution partners who are offering Brave for download, we need to make a set of silent installers available with each release for Win32 and Win64.

These installers should require no interaction and ideally be invisible.
They should automatically launch the newly-installed app following installation.
With each release, the silent installers should automatically be published to the web, just as existing installers are today. The distribution partners will link to the files that Brave hosts.

A more detailed spec is here:

https://docs.google.com/document/d/1gcpVFtHQqk1TndFFRiCFepil4isc_RhRNS6JCKMSQ1s/edit

@bbondy
Copy link
Member

bbondy commented Nov 28, 2018

marking 0.57.x milestone

@kjozwiak kjozwiak added the QA/No label Nov 29, 2018
@kjozwiak
Copy link
Member

kjozwiak commented Nov 29, 2018

Labelling this as QA/No. @davidtemkin @mbacchi please let me know if there's anything QA can specifically check/verify here.

@bsclifton bsclifton modified the milestones: 0.57.x - Beta, Dupe / Invalid / Not actionable Nov 29, 2018
@bsclifton
Copy link
Member

@mbacchi @w0ts0n was this closed out? (ex: we publish these on Releases page) or do we still have work to do?

I know you all helped provide me personally with a silent installer, but I don't recall seeing silent install versions on https://github.com/brave/brave-browser/releases

@mbacchi
Copy link
Contributor

mbacchi commented Nov 30, 2018

@bsclifton I have finished the parts that build and upload the silent installer (and untagged installer) to Github. The part that uploads this silent installer to the S3 bucket we use for the releases (brave-browser-downloads) is still manual for now but will be automated soon.

I probably should have not used this issue with the closing keywords for the PR above, instead I should have opened another issue for the PR only, and referenced that here when merged. In the future I'll try to do that so as not to close a tracking issue such as this one.

simonhong pushed a commit to brave/omaha that referenced this issue Jul 18, 2019
simonhong pushed a commit to brave/omaha that referenced this issue Sep 2, 2020
mihaiplesa pushed a commit to brave/omaha that referenced this issue Jun 12, 2021
mihaiplesa pushed a commit to brave/omaha that referenced this issue Jun 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment