Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unstoppable Domains layer 2 support for resolving eth address in brave wallet #22146

Closed
yrliou opened this issue Apr 7, 2022 · 2 comments · Fixed by brave/brave-core#13085
Closed

Unstoppable Domains layer 2 support for resolving eth address in brave wallet #22146

yrliou opened this issue Apr 7, 2022 · 2 comments · Fixed by brave/brave-core#13085
Assignees
@supermassive
Labels
feature/web3/unstoppable-domains Label for unstoppable domains feature feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.40.x - Release

Comments

@yrliou
Copy link
Member

yrliou commented Apr 7, 2022 •
edited
Loading

Ability to resolve domain registries under the Unstoppable Naming System (UNS) (.crypto, .x, .coin, .nft, .dao, .wallet, .888, .blockchain, and .bitcoin registries) on both Ethereum and Polygon chains to eth address in brave_wallet.

Resolving flow:
Resolve L2 and L1 domain

We should revise JsonRpcService::UnstoppableDomainsGetEthAddr to call contracts on Polygon first then ethereum if not found in Polygon.

Ref: Layer 1 support was implemented by brave/brave-core#10447.
@yrliou yrliou added feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop feature/web3/unstoppable-domains Label for unstoppable domains feature feature/web3/wallet/core labels Apr 7, 2022
@yrliou yrliou added this to Web3 Apr 7, 2022
@bbondy bbondy moved this to Backlog in Web3 Apr 11, 2022
@supermassive supermassive moved this from Backlog to In Progress in Web3 Apr 14, 2022
@supermassive supermassive mentioned this issue Apr 21, 2022
Merged
25 tasks
Repository owner moved this from In Progress to Done in Web3 Apr 25, 2022
@supermassive supermassive added this to the 1.40.x - Nightly milestone Apr 25, 2022
@srirambv
Copy link
Contributor

srirambv commented Jun 1, 2022

Brave 1.40.80 Chromium: 102.0.5005.78 (Official Build) beta (64-bit)
Revision df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS ☑️ Linux ☑️ Windows 11 Version 22H2
(Build 22621.1) 		☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified address on both L1 and L2 are resolved
22146-Linux.mp4
22146-Windows.mov
22146-macOS.mov

@srirambv
Copy link
Contributor

Removing Android label as this is be handled separately on Android via #23223

@srirambv srirambv removed the OS/Android Fixes related to Android browser functionality label Jun 17, 2022
@kjozwiak kjozwiak mentioned this issue Jun 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@supermassive supermassive

Labels
feature/web3/unstoppable-domains Label for unstoppable domains feature feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.40.x - Release
Development

Successfully merging a pull request may close this issue.

Polygon network for UD wallet address brave/brave-core
3 participants
@supermassive @yrliou @srirambv