Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[De-AMP] Miscellaneous fixes #22262

Closed
ShivanKaul opened this issue Apr 12, 2022 · 3 comments · Fixed by brave/brave-core#12999
Closed

[De-AMP] Miscellaneous fixes #22262

ShivanKaul opened this issue Apr 12, 2022 · 3 comments · Fixed by brave/brave-core#12999

Comments

@ShivanKaul
Copy link
Collaborator

@kjozwiak
Copy link
Member

The above will require 1.38.106 or higher for 1.38.x verification.

@Uni-verse
Copy link
Contributor

Verification completed on Samsung GS 21, Samsung Tab S7 using

Brave	1.38.106 Chromium: 101.0.4951.41 (Official Build) (64-bit) 
Revision	93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS	Android 12;
Enabled Disabled
Screen Shot 2022-04-25 at 11 36 35 AM Screen Shot 2022-04-25 at 11 48 06 AM
Screen Shot 2022-04-25 at 11 39 09 AM Screen Shot 2022-04-25 at 11 47 22 AM
Screen Shot 2022-04-25 at 11 39 51 AM Screen Shot 2022-04-25 at 11 46 11 AM
Screen Shot 2022-04-25 at 11 41 39 AM Screen Shot 2022-04-25 at 11 44 12 AM

@stephendonner
Copy link

stephendonner commented Apr 26, 2022

Verified PASSED using

Brave 1.38.107 Chromium: 101.0.4951.41 (Official Build) (x86_64)
Revision 93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS macOS Version 11.6.5 (Build 20G527)

Checked the URLs from the test plan: brave/brave-core#12999 (comment) and confirmed the amp attribute is not shown anywhere when de-AMP option is enabled.

de-AMP enabled de-AMP disabled
Screen Shot 2022-04-26 at 11 42 45 AM Screen Shot 2022-04-26 at 11 44 22 AM
Screen Shot 2022-04-26 at 11 59 51 AM Screen Shot 2022-04-26 at 12 00 36 PM
Screen Shot 2022-04-26 at 12 05 34 PM Screen Shot 2022-04-26 at 12 06 30 PM
Screen Shot 2022-04-26 at 12 10 53 PM Screen Shot 2022-04-26 at 12 08 43 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants