Adaptive captcha panel should remain active until solved

[emerick]

If you receive an adaptive captcha notification and then accidentally close the Rewards panel before solving the captcha, the captcha is no longer displayed and you must wait for the next notification to solve it.

cc: @fmarier

[LaurenWags]

Can be unblocked once https://bravesoftware.slack.com/archives/CB0KCRCQN/p1653423259020869 has an answer as this case needs to be checked as well.

[stephendonner]

Verified PASSED using

Brave	1.40.80 Chromium: 102.0.5005.78 (Official Build) beta (x86_64)
Revision	df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS	macOS Version 11.6.6 (Build 20G624)

Successful captcha - PASSED

1. Schedule a new captcha
2. Start the browser with --brave-ads-staging
3. When captcha notification appears, click Solve
4. Verify that adaptive captcha displays as overlay in Rewards panel
5. Close Rewards panel
6. Reopen Rewards panel and verify that adaptive captcha still displays
7. Solve Captcha
8. Verify that success modal overlay displays in Rewards panel
9. Dismiss success modal
10. Close Rewards panel
11. Reopen Rewards panel and verify that no adaptive captcha-related overlay displays

Confirmed no adaptive captcha displayed on restart

example	example	example	example	example

Rewards-icon disabled - PASSED

1. installed 1.40.80
2. launched Brave
3. opened brave://settings/appearance
4. toggled Show Brave Rewards icon in address bar to OFF/Disabled
5. opened brave://rewards/ and clicked on Start using Rewards
6. scheduled a captcha
7. dwindled unblinded payment tokens
8. waited for refill of tokens
9. restarted Brave due to Unblinded tokens refill is not scheduled after captcha is solved #20131
10. confirmed I saw the Solve / Later captcha dialog
11. clicked on Later
12. dwindled tokens to trigger refill
13. restarted
14. confirmed captcha reappeared
15. clicked on Solve
16. purposefully failed the captcha
17. dwindled tokens
18. restarted
19. confirmed captcha reappeared
20. successfully solved it
21. dwindled tokens for refill
22. scheduled a new captcha
23. confirmed I got a new captcha

example	example	example	example	example	example	example	example

Exceeding max attempts - PASSED

1. Schedule a new captcha
2. Start the browser with --brave-ads-staging
3. When captcha notification appears, click Solve
4. Verify that adaptive captcha displays as overlay in Rewards panel
5. Close Rewards panel
6. Reopen Rewards panel and verify that adaptive captcha still displays
7. Fail to solve captcha until "exceeded max attempts" error message displays
8. Dismiss error modal (will display support page in new tab)
9. Close Rewards panel
10. Reopen Rewards panel and verify that no adaptive captcha-related overlay displays
11. Captchas are now paused until you reset failed_attempts and paused settings in Preferences file (support would typically do this, however)

example	example	example	example	example	example

Confirmed:

• captchas were paused
• Preferences file contained failed_attempts count of 10 and paused true status

failed_attempts - 10	paused - true

Changed failed_attempts to 0 and paused to false in `Preferences, restarted, and re-issued a challenge

failed_attempts - 0	paused - false

Confirmed I received an adaptive-captcha challenge again:

[MadhaviSeelam]

Verification PASSED

Brave | 1.40.83 Chromium: 102.0.5005.78 (Official Build) beta (64-bit)
-- | --
Revision | df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS | Windows 11 Version 21H2 (Build 22000.675)

Successful captcha - PASSED

1. Schedule a new captcha
2. Start the browser with --brave-ads-staging
3. When captcha notification appears, click Solve
4. Verify that adaptive captcha displays as overlay in Rewards panel
5. Close Rewards panel
6. Reopen Rewards panel and verify that adaptive captcha still displays
7. Solve Captcha
8. Verify that success modal overlay displays in Rewards panel
9. Dismiss success modal
10. Close Rewards panel
11. Reopen Rewards panel and verify that no adaptive captcha-related overlay displays

Confirmed no adaptive captcha displayed on restart

Step3	Step7	Step7	Step8

Rewards-icon disabled - PASSED

1. installed 1.40.83
2. launched Brave
3. opened brave://settings/appearance
4. toggled Show Brave Rewards icon in address bar to OFF/Disabled
5. opened brave://rewards/ and clicked on Start using Rewards
6. scheduled a captcha
7. dwindled unblinded payment tokens
8. waited for refill of tokens
9. restarted Brave due to Unblinded tokens refill is not scheduled after captcha is solved #20131
10. confirmed I saw the Solve / Later captcha dialog
11. clicked on Later
12. dwindled tokens to trigger refill
13. restarted
14. confirmed captcha reappeared
15. clicked on Solve
16. purposefully failed the captcha
17. dwindled tokens
18. restarted
19. confirmed captcha reappeared
20. successfully solved it
21. dwindled tokens for refill
22. scheduled a new captcha
23. confirmed I got a new captcha

Step4	Step10	Step15	Step19	Step20	Step22

Exceeding max attempts - PASSED

1. Schedule a new captcha
2. Start the browser with --brave-ads-staging
3. When captcha notification appears, click Solve
4. Verify that adaptive captcha displays as overlay in Rewards panel
5. Close Rewards panel
6. Reopen Rewards panel and verify that adaptive captcha still displays
7. Fail to solve captcha until "exceeded max attempts" error message displays
8. Dismiss error modal (will display support page in new tab)
9. Close Rewards panel
10. Reopen Rewards panel and verify that no adaptive captcha-related overlay displays
11. Captchas are now paused until you reset failed_attempts and paused settings in Preferences file (support would typically do this, however)

Step 1	Step 1	Step 4	Step 7	Step 8

Confirmed:

• captchas were paused
• Preferences file contained failed_attempts count of 10 and paused true status

failed_attempts count of 10	paused true

Changed failed_attempts to 0 and paused to false in `Preferences, restarted, and re-issued a challenge

failed_attempts to 0	paused to false

Confirmed I received an adaptive-captcha challenge again

Able to solve the captcha successfully.

ex	ex	ex

[btlechowski]

Verification passed on

Brave	1.40.87 Chromium: 102.0.5005.78 (Official Build) beta (64-bit)
Revision	df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS	Ubuntu 18.04 LTS

Successful captcha - PASSED

1. Schedule a new captcha
2. Start the browser with --brave-ads-staging
3. When captcha notification appears, click Solve
4. Verify that adaptive captcha displays as overlay in Rewards panel
5. Close Rewards panel
6. Reopen Rewards panel and verify that adaptive captcha still displays
7. Solve Captcha
8. Verify that success modal overlay displays in Rewards panel
9. Dismiss success modal
10. Close Rewards panel
11. Reopen Rewards panel and verify that no adaptive captcha-related overlay displays

Confirmed no adaptive captcha displayed on restart

Rewards-icon disabled - PASSED

1. installed 1.40.x
2. launched Brave
3. opened brave://settings/appearance
4. toggled Show Brave Rewards icon in address bar to OFF/Disabled
5. opened brave://rewards/ and clicked on Start using Rewards
6. scheduled a captcha
7. dwindled unblinded payment tokens
8. waited for refill of tokens
9. restarted Brave due to Unblinded tokens refill is not scheduled after captcha is solved #20131
10. confirmed I saw the Solve / Later captcha dialog
11. clicked on Later
12. dwindled tokens to trigger refill
13. restarted
14. confirmed captcha reappeared
15. clicked on Solve
16. purposefully failed the captcha
17. dwindled tokens
18. restarted
19. confirmed captcha reappeared
20. successfully solved it
21. dwindled tokens for refill
22. scheduled a new captcha
23. confirmed I got a new captcha

Exceeding max attempts - PASSED

1. Schedule a new captcha
2. Start the browser with --brave-ads-staging
3. When captcha notification appears, click Solve
4. Verify that adaptive captcha displays as overlay in Rewards panel
5. Close Rewards panel
6. Reopen Rewards panel and verify that adaptive captcha still displays
7. Fail to solve captcha until "exceeded max attempts" error message displays
8. Dismiss error modal (will display support page in new tab)
9. Close Rewards panel
10. Reopen Rewards panel and verify that no adaptive captcha-related overlay displays
11. Captchas are now paused until you reset failed_attempts and paused settings in Preferences file (support would typically do this, however)

Confirmed:

• captchas were paused
• Preferences file contained failed_attempts count of 10 and paused true status

Changed failed_attempts to 0 and paused to false in `Preferences, restarted, and re-issued a challenge

Confirmed I received an adaptive-captcha challenge again: