Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't validate UD wallet address. #22498

Closed
supermassive opened this issue Apr 22, 2022 · 2 comments · Fixed by brave/brave-core#13210
Closed

Can't validate UD wallet address. #22498

supermassive opened this issue Apr 22, 2022 · 2 comments · Fixed by brave/brave-core#13210
Assignees
@Douglashdaniel
Labels
feature/web3/unstoppable-domains Label for unstoppable domains feature feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include security
Milestone
1.40.x - Release

Comments

@supermassive
Copy link

No way to get full wallet address when using UD domain.
Need, for example, a tooltip here or something better.
image
@supermassive supermassive added OS/Desktop feature/web3/unstoppable-domains Label for unstoppable domains feature labels Apr 22, 2022
@supermassive
Copy link
Author

@Douglashdaniel fyi

@yrliou yrliou added this to Web3 Apr 22, 2022
@yrliou yrliou added feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes labels Apr 22, 2022
@Douglashdaniel Douglashdaniel self-assigned this Apr 27, 2022
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Apr 27, 2022
@Douglashdaniel Douglashdaniel mentioned this issue Apr 28, 2022
Merged
24 tasks
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Apr 28, 2022
@Douglashdaniel Douglashdaniel added this to the 1.40.x - Nightly milestone Apr 29, 2022
Repository owner moved this from In Review to Done in Web3 Apr 29, 2022
@srirambv
Copy link
Contributor

srirambv commented Jun 1, 2022

Brave 1.40.80 Chromium: 102.0.5005.78 (Official Build) beta (64-bit)
Revision df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS ☑️ Linux ☑️ Windows 11 Version 22H2
(Build 22621.1) 		☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from brave/brave-core#13210
  • Verified hovering over Account name shows account address in tooltip
  • Verified hovering over receiving account name shows receiving account address in tooltip
  • Verified account address is shown on token approval prompts
  • Verified hovering over an UD name shows full account address in tooltip
UD Tooltip, Confirm Transaction Tooltips, Transaction Details Tooltips
22498-UD.Transaction.Tooltips-Linux.mp4
22498-UD.Transaction.Tooltips-Windows.mov
22498-UD.Transaction.Tooltips-macOS.mov
ERC20 Approve Tooltip
22498-ERC20.Approval-Linux.mp4
22498-ERC20.Approval-Windows.mov
22498-ERC20.Approval-macOS.mov

@kjozwiak kjozwiak mentioned this issue Jun 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/unstoppable-domains Label for unstoppable domains feature feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include security
Projects
Web3
Archived in project
Milestone
1.40.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): Show Full Addresses in Tooltips brave/brave-core
5 participants
@supermassive @diracdeltas @yrliou @srirambv @Douglashdaniel