-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to context-click remove Brave Rewards (BAT) icon #22525
Comments
@mkarolin noted that we might've purposely disabled context menu/right click for icons that appear inside the address bar, and that it's our own code. That might've been intentional, so may need discussion about that functionality. |
I looked back at the history here. We added a toggle in the settings to hide the icon in #2975, but it was - at the time - limited to when Rewards was disabled (when we had a Rewards on/off switch). When we removed the Rewards on/off switch in #11467 we also adjusted the toggle to always be able to hide the icon. Since we already have a way to hide it, there's no counterindication, IMO, to adding a way to do it via the context menu. |
QA Plan:
Expected result:
Expected result:
Expected result:
Expected result: |
Verification PASSED on
|
Verified
|
Filled #23124 |
Description
No option to context-click remove Brave Rewards (BAT) icon, unlike Wallet and VPN icons
Steps to Reproduce
1.40.5
Rewards
(BAT) icon in the URL barWallet
icon in the browser toolbarVPN
andSKUs SDKs
viabrave://flags
Relaunch
to restart BraveActual result:
We provide the ability to remove the
Wallet
andVPN
icons via context-clicks, but not theRewards
/BAT icon.Expected result:
Consistency - note you can remove it via
Show Brave Rewards icon in address bar
inbrave://settings/appearance
.Also note the text differences already, in #22436.
Reproduces how often:
100%
Brave version (brave://version info)
cc @rebron @Miyayes @bsclifton
The text was updated successfully, but these errors were encountered: