-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hook up About Brave Firewall + VPN
link in Settings dialog
#22695
Comments
This is thrown in the console:
|
About Brave Firewall + VPN
link in Settings dialog
@spylogsster was this also fixed with #22874 or a different issue? |
yes, should be fixed there |
Confirmed it is, but I'll use this to put my verification notes + mark/label it, once done 👍 |
Verified
|
Brave | 1.41.19 Chromium: 102.0.5005.61 (Official Build) nightly (x86_64) |
---|---|
Revision | 0e59bcc00cc4985ce39ad31c150065f159d95ad3-refs/branch-heads/5005@{#819} |
OS | macOS Version 11.6.6 (Build 20G624) |
Confirmed clicking on the About Brave Firewall + VPN
link loads https://brave.com/firewall-vpn/
in a new tab
Verification
Reproduced in Confirmed clicking on the About Brave Firewall + VPN link loads https://brave.com/firewall-vpn/ in a new tab
|
Description
Hook up
About Brave Firewall + VPN
link inSettings
dialogSteps to Reproduce
1.39.91
https://bravesoftware.slack.com/archives/CC5SA8CCB/p1651597201141019?thread_ts=1651597077.189229&cid=CC5SA8CCB
VPN
buttonSettings
(gears) buttonAbout Brave Firewall + VPN
Actual result:
Nothing happens
Expected result:
Should go to
brave.com/firewall-vpn
Reproduces how often:
100%
Brave version (brave://version info)
Version/Channel Information:
no
yes
yes
cc @nullhook @bsclifton @brave/qa-team
The text was updated successfully, but these errors were encountered: