Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook up About Brave Firewall + VPN link in Settings dialog #22695

Closed
stephendonner opened this issue May 4, 2022 · 6 comments
Closed

Hook up About Brave Firewall + VPN link in Settings dialog #22695

stephendonner opened this issue May 4, 2022 · 6 comments

Comments

@stephendonner
Copy link

stephendonner commented May 4, 2022

Description

Hook up About Brave Firewall + VPN link in Settings dialog

Steps to Reproduce

  1. install 1.39.91
  2. follow instructions to set up VPN: https://bravesoftware.slack.com/archives/CC5SA8CCB/p1651597201141019?thread_ts=1651597077.189229&cid=CC5SA8CCB
  3. click on the VPN button
  4. click on the Settings (gears) button
  5. click on About Brave Firewall + VPN
example example
Screen Shot 2022-05-04 at 10 43 47 AM Screen Shot 2022-05-04 at 10 43 39 AM

Actual result:

Nothing happens

Expected result:

Should go to brave.com/firewall-vpn

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.39.91 Chromium: 101.0.4951.54 (Official Build) beta (x86_64)
Revision 67da1aeb32cedd27634ca6634fb79cbd85d3f0ab-refs/branch-heads/4951@{#1126}
OS macOS Version 11.6.5 (Build 20G527)

Version/Channel Information:

  • Can you reproduce this issue with the current release? no
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

cc @nullhook @bsclifton @brave/qa-team

@stephendonner stephendonner changed the title Hook up About Brave Firewall + VPN Hook up About Brave Firewall + VPN link in Settings dialog May 4, 2022
@stephendonner
Copy link
Author

This is thrown in the console:

[15650:259:0505/184712.138182:ERROR:CONSOLE(29)] "Uncaught TypeError: Cannot read properties of undefined (reading 'create')", source: chrome-untrusted://vpn-panel.top-chrome/brave_vpn_panel.bundle.js (29)

@stephendonner stephendonner changed the title Hook up About Brave Firewall + VPN link in Settings dialog Hook up About Brave Firewall + VPN link in Settings dialog May 7, 2022
@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label May 19, 2022
@stephendonner
Copy link
Author

@spylogsster was this also fixed with #22874 or a different issue?

@spylogsster
Copy link

yes, should be fixed there

@stephendonner
Copy link
Author

yes, should be fixed there

Confirmed it is, but I'll use this to put my verification notes + mark/label it, once done 👍

@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.41.19 Chromium: 102.0.5005.61 (Official Build) nightly (x86_64)
Revision 0e59bcc00cc4985ce39ad31c150065f159d95ad3-refs/branch-heads/5005@{#819}
OS macOS Version 11.6.6 (Build 20G624)

Confirmed clicking on the About Brave Firewall + VPN link loads https://brave.com/firewall-vpn/ in a new tab

Screen Shot 2022-05-26 at 6 28 57 PM

@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.41.74 Chromium: 103.0.5060.53 (Official Build) beta (64-bit)
-- | --
Revision | a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS | Windows 11 Version 21H2 (Build 22000.739)

Reproduced in 1.40.100 Chromium: 102.0.5005.125 beta

Confirmed clicking on the About Brave Firewall + VPN link loads https://brave.com/firewall-vpn/ in a new tab

Ex1 Ex2
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants