Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better handling for web3_clientVersion #22799

Closed
srirambv opened this issue May 12, 2022 · 1 comment
Closed

Add better handling for web3_clientVersion #22799

srirambv opened this issue May 12, 2022 · 1 comment
Labels
closed/no-milestone feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

Android version of #19278

Issue posted here to discuss: https://github.com/brave/security/issues/650

But I think BraveWallet/v is an appropriate value instead of asking Infura.

For test plan see the pull request brave/brave-core#12900

@srirambv srirambv added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels May 12, 2022
@bbondy
Copy link
Member

bbondy commented May 14, 2022

Nothing else needed here, it's already implemented via #19278
If you want to just test this with the dapps release then you can close it and link to it in the test plan of another issue for dapps
I think we probably don't nee this separate issue though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/no-milestone feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality QA/Yes release-notes/include
Projects
Archived in project
Development

No branches or pull requests

2 participants