Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shields breaking fonts on Feedly - follow up to #23489 #23541

Closed
kjozwiak opened this issue Jun 17, 2022 · 4 comments · Fixed by brave/brave-core#13892
Closed

Shields breaking fonts on Feedly - follow up to #23489 #23541

kjozwiak opened this issue Jun 17, 2022 · 4 comments · Fixed by brave/brave-core#13892
Assignees
Labels
bug feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields OS/Desktop OS/Windows priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude

Comments

@kjozwiak
Copy link
Member

Description

As described via several reports from #23093 (comment) & #23489, the fonts under Feedly are broken when you have shields enabled with FP due to introducing Font FP via 1.39.x.

The issue was fixed for macOS via #23489 and uplifted into 1.41.x & 1.40.x via brave/brave-core#13822 & brave/brave-core#13823 but is still having some issues on Win. You'll notice that the font(s) still appear broken under Feedly on new profiles until Brave is restarted several times. Usually after two restarts, the fonts start being displayed correctly.

Steps to Reproduce

Quick note that the current behaviour requires several restarts for the fonts to appear correctly. This issue addresses that problem.

Actual result:

image

Expected result:

image

Reproduces how often:

100% reproducible using the STR/Cases outlined above.

Brave version (brave://version info)

Brave | 1.42.3 Chromium: 103.0.5060.53 (Official Build) nightly (64-bit)
-- | --
Revision | a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS | Windows 11 Version 21H2 (Build 22000.708)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? Yes
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

@kjozwiak
Copy link
Member Author

Closing as the above will be fixed via brave/brave-core#13892 which is also being uplifted into 1.41.x & 1.41.x and will go out in a HF.

@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.40.107 Chromium: 103.0.5060.53 (Official Build) (64-bit)
-- | --
Revision | a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS | Windows 10 Version 21H2 (Build 19044.1766)

@LaurenWags
Copy link
Member

Verified with

Brave | 1.40.107 Chromium: 103.0.5060.53 (Official Build) (x86_64)
-- | --
Revision | a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS | macOS Version 12.4 (Build 21F79)
  • Confirmed that without a browser restart, the expected font is shown on https://feedly.com/
  • Compared to Chrome, same look on both
Brave Chrome
feedly brave feedly chrome

@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.40.107 Chromium: 103.0.5060.53 (Official Build) (64-bit)
-- | --
Revision | a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS | Windows 11 Version 21H2 (Build 22000.739)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields OS/Desktop OS/Windows priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
6 participants