Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up to #24075 - Adjust translate initialization timeouts as validation fails in Win 11 x64 in the initial attempt #24777

Closed
MadhaviSeelam opened this issue Aug 18, 2022 · 6 comments · Fixed by brave/brave-core#14764

Comments

@MadhaviSeelam
Copy link

Description

Followed STR from #24075 (comment) and validation is still failing in Win 11 x64. Translation error is shown initially after enabling 3G slow throttling but works subsequently after retry or reload the page.

Steps to Reproduce

  1. install 1.43.71
  2. launch Brave
  3. relaunch Brave to enable Brave translate flag via griffin
  4. visit https://lemonde.fr
  5. open devtools>>Network tab>>enable 3G slow throttling.
  6. click Brave translate and translate the page.

Actual result:

The page could not be translation error shown

2022-08-17_12h09_50.mp4

Expected result:

No errors

Reproduces how often:

Easily

Brave version (brave://version info)

Brave 1.43.71 Chromium: 104.0.5112.81 (Official Build) beta (64-bit)
Revision 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS Windows 11 Version 21H2 (Build 22000.856)

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? N/A

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@LaurenWags
Copy link
Member

cc @rebron

@rebron rebron added the QA/Yes label Aug 19, 2022
@rebron
Copy link
Collaborator

rebron commented Aug 19, 2022

cc: @atuchin-m

@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Aug 19, 2022
@btlechowski
Copy link

Reproduced on

Brave 1.43.78 Chromium: 104.0.5112.102 (Official Build) beta (64-bit)
Revision 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS Ubuntu 18.04 LTS

image

@Uni-verse
Copy link
Contributor

Reproduced on Samsung Galaxy S 21 & Samsung Galaxy Tab S7 using the following build:

Brave	1.43.74 Chromium: 104.0.5112.102 (Official Build) beta (64-bit) 
Revision	8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS	Android 12; Build/SP1A.210812.016
translate_init01.mp4

Screen Shot 2022-08-23 at 10 53 52 AM

@kjozwiak
Copy link
Member

The above will require 1.43.82 or higher for 1.43.x verification 👍

@MadhaviSeelam
Copy link
Author

Verification PASSED using

Brave | 1.43.84 Chromium: 105.0.5195.68 (Official Build) (64-bit)
-- | --
Revision | ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS | Windows 11 Version 21H2 (Build 22000.856)

Verified using original STR from #24777 (comment)
Confirmed translation is successful and no timeouts occurring at Slow 3G throttling

2022-08-30_13h41_44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants