Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

same device gets listed multiple times #2496

Closed
LaurenWags opened this issue Dec 12, 2018 · 3 comments
Closed

same device gets listed multiple times #2496

LaurenWags opened this issue Dec 12, 2018 · 3 comments

Comments

@LaurenWags
Copy link
Member

Description

Found when https://github.com/brave/browser-android-tabs/issues/924 was encountered

It seems like if there's a problem syncing one device on the chain, it gets listed multiple times on another device.

Steps to Reproduce

  1. Clean profile on macOS
  2. Import some bookmarks (about 45 from a bookmark file and 7 from safari)
  3. Create Sync chain.
  4. Clean install of 1.0.71 (sync 2) on Android.
  5. Add some bookmarks (I had 5 bookmarks across 3 folders)
  6. Join sync chain. (used QR code scanner)
  7. Get stuck in Loading screen on Android device (https://github.com/brave/browser-android-tabs/issues/924)
  8. After trying to get Brave install to work on Android, I looked back at the macOS device and saw that the same Android device was listed multiple times

Actual result:

samedevicelistedmultipletimes

Expected result:

Device should only be listed once

Reproduces how often:

Unsure, only ran into it in this case.

Brave version (brave://version info)

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta(64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

@LaurenWags LaurenWags added this to the 1.x Backlog milestone Dec 12, 2018
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Dec 12, 2018
@AlexeyBarabash
Copy link
Contributor

@AlexeyBarabash
Copy link
Contributor

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 26, 2018

Verification passed on

Brave 0.59.12 Chromium: 72.0.3626.17 (Official Build) beta (64-bit)
Revision 08d2140079f8db14c9eb885a803d231b1a30e817-refs/branch-heads/3626@{#315}
OS Windows 10
  • Verified the STR from description

Verification passed on

Brave 0.59.12 Chromium: 72.0.3626.17 (Official Build) beta (64-bit)
Revision 08d2140079f8db14c9eb885a803d231b1a30e817-refs/branch-heads/3626@{#315}
OS Linux

  • Verified the STR from description

Verified passed with

Brave 0.59.18 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants