Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foreground/Background notifications aren't implemented on Linux for Brave Ads #2511

Closed
tmancey opened this issue Dec 12, 2018 · 4 comments · Fixed by brave/brave-core#1482
Closed

Comments

@tmancey
Copy link
Contributor

tmancey commented Dec 12, 2018

Foreground/Background notifications aren't implemented on Linux for Brave Ads

@tmancey tmancey added this to the 1.x Backlog milestone Dec 12, 2018
@tmancey tmancey changed the title Foreground/Background notifications aren't implemented on Linux Foreground/Background notifications aren't implemented on Linux for Brave Ads Dec 12, 2018
bridiver added a commit to brave/brave-core that referenced this issue Jan 29, 2019
@bridiver
Copy link
Contributor

@tmancey this needs steps for QA

@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@tmancey
Copy link
Contributor Author

tmancey commented Feb 13, 2019

@bridiver This is just a reminder for us to implement background/foreground notifications for Ads in Linux. Once completed would this not be tested as part of overall Ads implementation?

@tmancey
Copy link
Contributor Author

tmancey commented Feb 20, 2019

@bridiver issues/2511 branch has been created but no PR, it would appear we need these fixes for Linux for Brave Ads Launch?

tmancey pushed a commit to brave/brave-core that referenced this issue Feb 27, 2019
@tmancey tmancey assigned tmancey and unassigned bridiver Mar 19, 2019
tmancey pushed a commit to brave/brave-core that referenced this issue Mar 20, 2019
tmancey pushed a commit to brave/brave-core that referenced this issue Apr 1, 2019
@tmancey tmancey added the priority/P2 A bad problem. We might uplift this to the next planned release. label Apr 5, 2019
tmancey pushed a commit to brave/brave-core that referenced this issue Apr 8, 2019
tmancey pushed a commit to brave/brave-core that referenced this issue Apr 8, 2019
@tmancey tmancey added this to the 0.65.x - Nightly milestone Apr 8, 2019
tmancey pushed a commit to brave/brave-core that referenced this issue Apr 9, 2019
tmancey pushed a commit to brave/brave-core that referenced this issue Apr 9, 2019
tmancey added a commit to brave/brave-core that referenced this issue Apr 9, 2019
tmancey added a commit to brave/brave-core that referenced this issue Apr 9, 2019
@srirambv
Copy link
Contributor

Verification passed on

Brave 0.63.40 Chromium: 74.0.3729.61 (Official Build) beta(64-bit)
Revision 5df2c8936783bd7575987e45d72a92fcf528496b-refs/branch-heads/3729@{#645}
OS Linux
[1:1:0416/102038.597386:INFO:ads_impl.cc(284)] TabUpdated.IsBlurred for tab id: 8 and url: https://brave.com/
[33299:33299:0416/102038.599741:INFO:ads_service_impl.cc(935)] AdsService Event Log: {"data":{"type":"blur","stamp":"2019-04-16T10:20:38Z","tabId":5}}
[33299:33299:0416/102038.599909:INFO:ads_service_impl.cc(935)] AdsService Event Log: {"data":{"type":"blur","stamp":"2019-04-16T10:20:38Z","tabId":7}}
[33299:33299:0416/102038.600012:INFO:ads_service_impl.cc(935)] AdsService Event Log: {"data":{"type":"blur","stamp":"2019-04-16T10:20:38Z","tabId":8}}
[33299:33299:0416/102038.600103:INFO:ads_service_impl.cc(935)] AdsService Event Log: {"data":{"type":"background","stamp":"2019-04-16T10:20:38Z"}}
[1:1:0416/102038.607822:INFO:client.cc(267)] Successfully saved client state
[1:1:0416/102038.609690:INFO:client.cc(267)] Successfully saved client state
[1:1:0416/102038.612136:INFO:client.cc(267)] Successfully saved client state
[1:1:0416/102049.531336:INFO:ads_impl.cc(284)] TabUpdated.IsBlurred for tab id: 5 and url: https://www.wsj.com/articles/notre-dame-blaze-extinguished-officials-assess-damage-11555406812?mod=hp_lead_pos1&mod=article_inline&mod=hp_lead_pos1
[1:1:0416/102049.532471:INFO:ads_impl.cc(284)] TabUpdated.IsBlurred for tab id: 7 and url: chrome://rewards/
[1:1:0416/102049.533366:INFO:ads_impl.cc(270)] TabUpdated.IsFocused for tab id: 8 and url: https://brave.com/
[33299:33299:0416/102049.536692:INFO:ads_service_impl.cc(935)] AdsService Event Log: {"data":{"type":"blur","stamp":"2019-04-16T10:20:49Z","tabId":5}}
[33299:33299:0416/102049.536916:INFO:ads_service_impl.cc(935)] AdsService Event Log: {"data":{"type":"blur","stamp":"2019-04-16T10:20:49Z","tabId":7}}
[33299:33299:0416/102049.540957:INFO:ads_service_impl.cc(935)] AdsService Event Log: {"data":{"type":"focus","stamp":"2019-04-16T10:20:49Z","tabId":8}}
[33299:33299:0416/102049.541173:INFO:ads_service_impl.cc(935)] AdsService Event Log: {"data":{"type":"foreground","stamp":"2019-04-16T10:20:49Z"}}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants