Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving pdfs by printing is broken #25186

Closed
GreenYellowLight opened this issue Sep 2, 2022 · 5 comments
Closed

Saving pdfs by printing is broken #25186

GreenYellowLight opened this issue Sep 2, 2022 · 5 comments
Labels
Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix closed/by-author feature/pdf OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon.

Comments

@GreenYellowLight
Copy link

Normally when you have a pdf you can select the button in the top right and then 'print' to pdf to a folder on your computer. This is helpful as unlike the download button it allows for custom page selection.

However as of the last update this functionality has become broken.

Steps to Reproduce

  1. Put brave in fullscreen mode
  2. Open a pdf in brave. eg http://filmeducation.org/pdf/

Screen Shot 2022-09-03 at 7 26 34 am

resources/primary/Brave.pdf 3. Press the print button in the top right

Screen Shot 2022-09-03 at 7 26 46 am

  1. Press the save button

Screen Shot 2022-09-03 at 7 26 54 am

  1. Screen becomes greyed out. Expected behaviour is that you will be given the mac option thing of where to save the file to

Screen Shot 2022-09-03 at 7 27 03 am

Actual result:

Screen becomes greyed out

Screen Shot 2022-09-03 at 7 27 03 am

Expected result:

There is an option of where to save the file to and you can save the pdf (or part of it) somewhere

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.42.97 Chromium: 104.0.5112.102 (Official Build) (x86_64)
Revision 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS macOS Version 12.5.1 (Build 21G83)

Version/Channel Information:

I don't know

Other Additional Information:

Issue only happens in fullscreen mode

Miscellaneous Information:

@rebron
Copy link
Collaborator

rebron commented Sep 27, 2022

@GreenYellowLight We just released 1.44.101. Can you update to the latest version and let us know if you're still having issues with saving the pdf via print dialog.

@rebron rebron added needs-more-info The report requires more detail before we can decide what to do with this issue. priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Sep 27, 2022
@rebron rebron added the Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix label Oct 4, 2022
@rebron
Copy link
Collaborator

rebron commented Oct 4, 2022

@GreenYellowLight Are you seeing this same issue with Chrome if you still have that browser installed?

@GreenYellowLight
Copy link
Author

@GreenYellowLight Are you seeing this same issue with Chrome if you still have that browser installed?

On chrome the issue does not exist
Screen Shot 2022-10-05 at 1 14 34 pm

@GreenYellowLight
Copy link
Author

A recent update fixed this issue

@rebron rebron added closed/by-author and removed needs-more-info The report requires more detail before we can decide what to do with this issue. labels Nov 1, 2022
@rebron
Copy link
Collaborator

rebron commented Nov 1, 2022

@GreenYellowLight Thanks for the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix closed/by-author feature/pdf OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon.
Projects
None yet
Development

No branches or pull requests

2 participants