Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't login into https://riot.im due to shields blocking cross-origin requests #2521

Closed
jryans opened this issue Dec 13, 2018 · 3 comments
Closed

Comments

@jryans
Copy link

jryans commented Dec 13, 2018

Description

A user reported that our site was broken in Brave. It appears that the Brave mode "3rd-party cookies blocked" also blocks cross-origin requests, which seems like a bug based on the setting's name.

Steps to Reproduce

  1. Set cooking mode to "3rd-party cookies blocked"
  2. Go to https://riot.im/app/#/register
  3. You will see the error message "Unable to query for supported registration methods"

Actual result:

2018-12-13 at 10 51

Expected result:

If I set to allow cookies, then I get:

2018-12-13 at 10 52

Reproduces how often:

Always.

Brave version (brave://version info)

Brave | 0.57.18 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision | 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS | Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Yes, reproduces on Dev as well.

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
    Yes, disabling the shield (or just changing the cookies part) resolves it.
  • Is the issue reproducible on the latest version of Chrome?
    No, Chrome works correctly.
@jeroenev
Copy link

have been noticing the same for about a day
other example is https://deltablue.cloud/#/account/login

@tildelowengrimm tildelowengrimm added the webcompat/shields Shields is breaking a website. label Dec 19, 2018
@tildelowengrimm tildelowengrimm added this to the 1.x Backlog milestone Dec 19, 2018
@iefremov
Copy link
Contributor

iefremov commented Jan 9, 2019

Should fixed as a duplicate of #2252

@btlechowski
Copy link

btlechowski commented Jan 9, 2019

Verification passed on

Brave 0.58.20 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Windows 7

image

Verification PASSED on Mint 19.1 x64 VM using the following build:

Brave 0.58.20 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Linux

screen shot 2019-01-09 at 6 03 57 pm

  • registered for a new account without any issues
  • logged into my personal account and ensured that I could login without any issues

Verified passed with

Brave 0.58.20 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Mac OS X

screen shot 2019-01-09 at 8 04 44 pm

@kjozwiak kjozwiak changed the title "3rd-party cookies blocked" seems to also block cross-origin requests as well can't login into https://riot.im due to shields blocking cross-origin requests Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants