Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Firebase SDK #25615

Closed
SergeyZhukovsky opened this issue Sep 26, 2022 · 1 comment
Closed

Remove Firebase SDK #25615

SergeyZhukovsky opened this issue Sep 26, 2022 · 1 comment
Assignees
@SergeyZhukovsky
Labels
enhancement OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude

Comments

@SergeyZhukovsky
Copy link
Member

Currently we include firebase SDK libs on Android, but we don't use them. They were disabled back in 2018 in that PRs
brave/brave-core#714
brave/brave-core#908
We need to get rid of that dependency.
@SergeyZhukovsky SergeyZhukovsky added enhancement QA/No release-notes/exclude OS/Android Fixes related to Android browser functionality labels Sep 26, 2022
@SergeyZhukovsky SergeyZhukovsky self-assigned this Sep 26, 2022
@SergeyZhukovsky SergeyZhukovsky added the priority/P3 The next thing for us to work on. It'll ride the trains. label Sep 26, 2022
@SergeyZhukovsky SergeyZhukovsky mentioned this issue Sep 28, 2022
Closed
25 tasks
@SergeyZhukovsky
Copy link
Member Author

Closing without fixing it. Details are here brave/brave-core#15260 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SergeyZhukovsky SergeyZhukovsky

Labels
enhancement OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removes Firebase SDK on Android brave/brave-core
1 participant
@SergeyZhukovsky