Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gray out Ads Panel for certain countries #2562

Closed
mandar-brave opened this issue Dec 13, 2018 · 5 comments · Fixed by brave/brave-core#1941
Closed

Gray out Ads Panel for certain countries #2562

mandar-brave opened this issue Dec 13, 2018 · 5 comments · Fixed by brave/brave-core#1941

Comments

@mandar-brave
Copy link

mandar-brave commented Dec 13, 2018

We will need a mechanism to prevent opt-in for Brave Ads for certain countries and provide an alternate grayed out Brave Rewards: Ads Panel experience.

List of countries will be provided offline and should be configurable.

@NejcZdovc

@mandar-brave mandar-brave added feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. labels Dec 13, 2018
@mandar-brave
Copy link
Author

@jenn-rhim when ready, update the issue with the right image.

@NejcZdovc NejcZdovc added this to the 1.x Backlog milestone Dec 27, 2018
@jsecretan
Copy link

The ads panel should be greyed out for all but: US, Canada, Germany, France, UK as those are the only places where we are launching ads to start.

@jenn-rhim
Copy link

Here is the version for the 'Ads unavailable in your region' case.

screen shot 2019-01-28 at 8 24 00 am

cc @mandar-brave

@srirambv
Copy link
Contributor

srirambv commented Apr 9, 2019

QA Blocked on #3967 on Linux

@srirambv
Copy link
Contributor

srirambv commented Apr 22, 2019

Verification passed on

Brave 0.63.46 Chromium: 74.0.3729.91 (Official Build) (64-bit)
Revision 03844ed83e02b8add3f4b9cb859a7108d55b2e4d-refs/branch-heads/3729@{#860}
OS Linux
  • Verified for Australia
    image
  • Verified for India (Kannada) for translated text. Sorry message translations pending
    image

Verification passed on

Brave 0.63.46 Chromium: 74.0.3729.91 (Official Build) (64-bit)
Revision 03844ed83e02b8add3f4b9cb859a7108d55b2e4d-refs/branch-heads/3729@{#860}
OS Windows 10 OS Build 17134.523
  • Verified for India

image

  • Verified for India (Hindi) for the translated text. Sorry message translations pending
    image

Verified passed with

Brave 0.63.46 Chromium: 74.0.3729.91 (Official Build) (64-bit)
Revision 03844ed83e02b8add3f4b9cb859a7108d55b2e4d-refs/branch-heads/3729@{#860}
OS Mac OS X
  • Verified test plan from Disabling Ads Panel for disallowed regions brave-core#1941
  • Verified did not see 'Sorry' message when IP and Region were set appropriately for included regions (US, Can, UK, FR, DE)
  • Verified did see 'Sorry' message when IP and Region were set for non-included regions (Australia, Sweden, etc).
    Screen Shot 2019-04-22 at 4 13 46 pm
    Screen Shot 2019-04-22 at 16 36 06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants