-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable Phone/Computer buttons until the device name is queried #2724
Labels
about-pages/sync
feature/sync
priority/P4
Planned work. We expect to get to it "soon".
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/exclude
Milestone
Comments
srirambv
added
feature/sync
design/needs-mock-up
needs-mockup A feature which needs design mockup to be implemented.
priority/P4
Planned work. We expect to get to it "soon".
about-pages/sync
QA/Yes
release-notes/exclude
labels
Dec 24, 2018
cezaraugusto
added a commit
to brave/brave-core
that referenced
this issue
Jan 1, 2019
cezaraugusto
removed
the
design/needs-mock-up
needs-mockup A feature which needs design mockup to be implemented.
label
Jan 2, 2019
cezaraugusto
added a commit
to brave/brave-core
that referenced
this issue
Jan 2, 2019
cezaraugusto
added a commit
to brave/brave-core
that referenced
this issue
Jan 3, 2019
Verification passed on
Verification passed on
Verified passed with
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
about-pages/sync
feature/sync
priority/P4
Planned work. We expect to get to it "soon".
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/exclude
Test plan
See brave/brave-core#1193
Description
Disable Phone/Computer buttons until the device name is queried
Steps to Reproduce
brave://sync
Let’s sync a new device with “”.
while its being queriedComputer
, doesn't show the code wordsPhone/Tablet
doesn't show the QR codebrave://sync
, device name is instantly queried and you can see the QR/code words with appropriate option being selectedActual result:
https://youtu.be/P4_vqKroqHc
Expected result:
Should query device name instantly and the computer/phone/tablet buttons should be inactive if there is a delay in getting the device name
Reproduces how often:
Easy
Brave version (brave://version info)
Reproducible on current release:
Yes
Website problems only:
N/A
N/A
Additional Information
cc: @bradleyrichter for design input
@rebron @brave/legacy_qa
The text was updated successfully, but these errors were encountered: