Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Backup Wallet' Should Link to Backup Page #2739

Closed
jonathansampson opened this issue Dec 25, 2018 · 2 comments · Fixed by brave/brave-core#1641
Closed

'Backup Wallet' Should Link to Backup Page #2739

jonathansampson opened this issue Dec 25, 2018 · 2 comments · Fixed by brave/brave-core#1641

Comments

@jonathansampson
Copy link
Contributor

Description

Backup Wallet prompt doesn't navigate to the backup-view in Rewards.

Steps to Reproduce

Click Backup Wallet from the following prompt:

image

Actual result:

Not taken to backup wallet view

Expected result:

Should be taken directly to backup wallet view

Reproduces how often:

Always

Brave version (brave://version info)

0.58.18

Reproducible on current release:

Yes

Additional Information

Originally implemented here: #1164

@NejcZdovc NejcZdovc added this to the 1.x Backlog milestone Dec 27, 2018
@NejcZdovc NejcZdovc added needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. and removed bug labels Dec 27, 2018
@NejcZdovc NejcZdovc added priority/P2 A bad problem. We might uplift this to the next planned release. and removed needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. labels Jan 21, 2019
@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@ryanml ryanml removed the blocked label Feb 11, 2019
@ryanml
Copy link
Contributor

ryanml commented Feb 11, 2019

This one is no longer blocked

@btlechowski
Copy link

btlechowski commented Mar 6, 2019

Verification passed on

Brave 0.62.17 Chromium: 73.0.3683.39 (Official Build) dev (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Windows 7 Service Pack 1 Build 7601.24312

Used test plan from brave/brave-core#1641

Added: "backup_notification_frequency":"50000000","backup_notification_interval":"50000000"
to brave.rewards section of Preferences file

2739

Verification PASSED on macOS 10.14.3 x64 using the following build:

Brave 0.62.27 Chromium: 73.0.3683.75 (Official Build) beta(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Mac OS X

examplePass

Verification passed on

Brave 0.62.32 Chromium: 73.0.3683.75 (Official Build) beta(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Linux
  • Verification done by adding "backup_notification_frequency":"50000000","backup_notification_interval":"50000000" into the brave.rewards section of the Preferences file
    ezgif com-video-to-gif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants