-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync Chain Code/QR Code disappearing when importing code fails #2812
Labels
bug
closed/wontfix
feature/sync
fixed-with-sync-v2
priority/P4
Planned work. We expect to get to it "soon".
QA/Yes
Comments
kjozwiak
added
bug
feature/sync
priority/P3
The next thing for us to work on. It'll ride the trains.
QA/Yes
labels
Jan 3, 2019
kjozwiak
removed
the
priority/P3
The next thing for us to work on. It'll ride the trains.
label
Jan 3, 2019
Removed |
Reproduced on
|
This is also reproduced when you reset sync and try to enable sync again as mentioned in scenario 2 in #2801 |
Reproducible on
|
Can reproduce it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
closed/wontfix
feature/sync
fixed-with-sync-v2
priority/P4
Planned work. We expect to get to it "soon".
QA/Yes
Description
When you you fail a sync chain code import via
Enter a sync chain code
, the code and QR code underStart a new sync chain
will won't be displayed as exampled below. Once you either refreshbrave://sync
or close/re-open, the code and QR code will re-appear.Steps to Reproduce
0.59.14 Chromium: 72.0.3626.28
in this case)brave://sync
Start a new sync chain
and ensure that you have a code/QR codeEnter a sync chain code
Confirm Sync Code
and pressOK
when you get the errorStart a new sync chain
and you'll notice that the sync codes/QR are not being displayedActual result:
Expected result:
Reproduces how often:
100% reproducible when using the above STR.
Brave version (brave://version info)
Reproducible on current release:
Not reproducible using
0.58.18 Chromium: 71.0.3578.98
which is the current release. Opened0.58.18 Chromium: 71.0.3578.98
using--enable-brave-sync
and couldn't reproduce the issue. Seems when you pressOK
on the failed message, the entire modal is closed. With0.59.14 Chromium: 72.0.3626.28
, pressingOK
just closes the error message.Additional Information
Possibly related to #2602 & #2604. CCing @cezaraugusto
The text was updated successfully, but these errors were encountered: